-
Notifications
You must be signed in to change notification settings - Fork 6k
fix(desktop): dedupe Nostr session deep link imports #9918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DOsinga
merged 9 commits into
aaif-goose:main
from
harrykamboj1:fix/nostr-deeplink-duplicate-import
Jun 30, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3f0e62b
fix(desktop): dedupe Nostr session deep link imports
harrykamboj1 6388deb
Merge branch 'aaif-goose:main' into fix/nostr-deeplink-duplicate-import
harrykamboj1 8f8181f
Merge branch 'main' into fix/nostr-deeplink-duplicate-import
harrykamboj1 0a5ec09
fix(desktop): address review feedback on Nostr deep link dedup
harrykamboj1 99fa652
Merge branch 'main' into fix/nostr-deeplink-duplicate-import
harrykamboj1 7f5957b
fix(desktop): key burst dedup by URL for session deep links
harrykamboj1 626adde
Merge branch 'main' into fix/nostr-deeplink-duplicate-import
harrykamboj1 68ca5da
Merge branch 'main' into fix/nostr-deeplink-duplicate-import
harrykamboj1 7807277
fix(desktop): restore in-flight guard and defer deep-link dedup to re…
harrykamboj1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a
goose://sessions/...URL arrives just after a window's main frame stops loading but before React has installed theopen-shared-sessionlistener, this records the URL even though the IPC sent on the next line can be missed. The macOS duplicate delivered once the renderer is ready is then treated as a burst duplicate and dropped, so the user gets no import; queue untilreact-readyor an acknowledgement before recording the URL as sent.Useful? React with 👍 / 👎.