Skip to content

fix(summon): skip non-recipe project config files #9808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DOsinga merged 3 commits into from
Jun 17, 2026
Merged

fix(summon): skip non-recipe project config files #9808

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59773cb
fix(summon): skip non-recipe project config files
Thump604 Jun 15, 2026
6c91e43
Merge remote-tracking branch 'origin/main' into 604/summon-skip-proje…
Jun 17, 2026
18b7973
fix(summon): scope config-file warning suppression to working dir
Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions crates/goose/src/agents/platform_extensions/summon.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,12 @@ fn scan_recipes_from_dir(
});
}
Err(e) => {
// Files like package.json and tsconfig.json are common in project roots.
// Treat valid YAML/JSON that is missing Recipe fields as "not a recipe"
// rather than warning on every normal project config file.
if e.to_string().contains("missing field") {
continue;

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep warnings for malformed recipe-directory files

This skip applies to every directory scanned by discover_filesystem_sources, including .goose/recipes, .agents/recipes, configured recipe paths, and the working directory. In those recipe-specific locations, a real recipe with a typo or missing required field such as description now disappears with no warning, whereas other parse failures are still surfaced; limiting this suppression to known project config files or only the raw working-directory scan would avoid hiding broken user recipes.

Useful? React with 👍 / 👎.

}
warn!("Failed to parse recipe {}: {}", path.display(), e);
}
}
Expand Down Expand Up @@ -1998,6 +2004,34 @@ You review code."#;
assert_eq!(sources[0].name, "reviewer");
}

#[test]
fn test_recipe_scan_skips_non_recipe_project_config_files() {
let temp_dir = TempDir::new().unwrap();
fs::write(
temp_dir.path().join("package.json"),
r#"{"scripts":{"test":"cargo test"}}"#,
)
.unwrap();
fs::write(
temp_dir.path().join("tsconfig.json"),
r#"{"compilerOptions":{"strict":true}}"#,
)
.unwrap();
fs::write(
temp_dir.path().join("valid.yaml"),
"title: Valid\ndescription: Real recipe\ninstructions: Run valid steps",
)
.unwrap();

let mut sources = Vec::new();
let mut seen = HashSet::new();
scan_recipes_from_dir(temp_dir.path(), SourceType::Recipe, &mut sources, &mut seen);

assert_eq!(sources.len(), 1);
assert_eq!(sources[0].name, "valid");
assert_eq!(sources[0].description, "Real recipe");
}

#[tokio::test]
async fn test_discover_recipes_and_agents() {
let temp_dir = TempDir::new().unwrap();
Expand Down