Skip to content

fix(desktop): activate hermit on macOS so STDIO extensions resolve node #9482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamadeo merged 1 commit into from
Jun 22, 2026
Merged

fix(desktop): activate hermit on macOS so STDIO extensions resolve node #9482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions ui/desktop/src/bin/node-setup-common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ trap 'log "An error occurred. Exiting with status $?."' ERR

log "Starting node setup (common)."

# GUI-launched macOS apps inherit a minimal PATH that omits the system sbin
# directories, so Hermit's bootstrap cannot find tools like `chown` (which lives
# in /usr/sbin on macOS) and aborts with exit 127. Ensure they are reachable;
# this is harmless on Linux, where these paths are typically already present.
export PATH="/usr/sbin:/sbin:${PATH}"

if [ -n "${GOOSE_PATH_ROOT:-}" ]; then
RESOLVED_GOOSE_CONFIG_DIR="${GOOSE_PATH_ROOT}/config"
elif [ -n "${GOOSE_CONFIG_DIR:-}" ]; then
Expand Down Expand Up @@ -108,11 +114,13 @@ else
log "Hermit environment already initialized. Skipping init."
fi

# Activate the environment with output redirected to log
if [[ "$(uname -s)" == "Linux" ]]; then
log "Activating hermit environment."
{ . "bin/activate-hermit"; } >> "${LOG_FILE}" 2>&1
fi
# Activate the environment with output redirected to log.
# Activation must run on every platform: macOS GUI apps otherwise never get the
# hermit-managed node/npx onto PATH, so STDIO extensions fail with
# "env: node: No such file or directory". The Linux-only guard was introduced in
# #5372 to "preserve existing behavior" on macOS, but that path is now broken.
log "Activating hermit environment."
{ . "bin/activate-hermit"; } >> "${LOG_FILE}" 2>&1

# Install Node.js using hermit
log "Installing Node.js with hermit."
Expand Down