fix(ui): preserve pending env vars in Add Extension form

[williams145]

Summary

When adding an MCP extension via the desktop UI, env vars typed into the empty input row at the bottom of the Environment Variables section are silently dropped if the user clicks Save without first clicking "+ Add". MCPs that need secrets (most of them — API tokens, JWTs, etc.) then fail at activation with:

Failed to add extension: invalid config: Failed to fetch secret 'KEY_NAME' from config: Configuration value not found: KEY_NAME

This is an inconsistency with the sibling HeadersSection, which already handles this case correctly via pendingHeader + getFinalHeaders(). This PR mirrors the same pattern for env vars.

Change

EnvVarsSection.tsx now passes the pending { key, value } object alongside the boolean, the same way HeadersSection.tsx already does:

 React.useEffect(() => {
   const hasPendingInput = newKey.trim() !== '' || newValue.trim() !== '';
+  const pendingEnvVar =
+    newKey.trim() && newValue.trim() ? { key: newKey, value: newValue } : null;
-  onPendingInputChange?.(hasPendingInput);
+  onPendingInputChange?.(hasPendingInput, pendingEnvVar);
 }, [newKey, newValue, onPendingInputChange]);

ExtensionModal.tsx gets a matching pendingEnvVar state, a handlePendingEnvVarChange callback, and a getFinalEnvVars() helper (modeled on the existing getFinalHeaders()). handleSubmit now uses getFinalEnvVars() so the pending entry is included in both the storeSecret calls and the data passed to onSubmit.

Fixes #8969

Test plan

• Added regression test in ExtensionModal.test.tsx: typing JWT_TOKEN + my_very_long_token into the env-var row and clicking Submit without "+ Add" — verifies upsertConfig({ is_secret: true, key, value }) is called and onSubmit receives the entry with isEdited: true. This test fails on main and passes with this change.
• Added negative test: typing only a key (no value) does not trigger any upsertConfig call and does not appear in submitted data.
• Manual verification (recommended for reviewer):
  1. Run just run-ui
  2. Settings → Extensions → Add Extension
  3. Type a name, command, and a JWT_TOKEN + value in the env vars row — do NOT click "+ Add"
  4. Click Save
  5. Expected (after fix): extension activates successfully without "Configuration value not found"

Follow-up (separate PR)

While investigating I noticed EnvVarsSection.tsx:handleEdit (lines 112-125) builds a local newEnvVars array but never sends it back to the parent — so clicking the edit (pencil) icon on an existing •••••••• secret silently fails to mark it as edited. That's a related but distinct bug; I'll file a follow-up PR for it after this one lands.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38ab7179c5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Validate pending env var keys before auto-submitting

When a user clicks Save without pressing + Add, getFinalEnvVars() now appends pendingEnvVar based only on non-empty checks, so it bypasses the handleAdd rule that rejects keys containing spaces in EnvVarsSection. In that flow, values like "API KEY" are submitted to storeSecret/onSubmit even though the UI validation message says spaces are invalid, which can lead to invalid extension env configuration being persisted.

Useful? React with 👍 / 👎.

[DOsinga]

Fixed in ff284ee — getFinalEnvVars() now checks !pendingEnvVar.key.includes(' ') to match the handleAdd validation.

[DOsinga]

LGTM. Good fix — correctly mirrors the existing pendingHeader/getFinalHeaders() pattern for env vars.

I pushed one commit (ff284ee) to address the codex review comment: getFinalEnvVars() now also rejects keys with spaces, matching the handleAdd validation. Also made onPendingInputChange non-optional in EnvVarsSectionProps since it's always provided.

All 349 desktop tests pass locally. The CI Electron test failure on 38ab717 looks unrelated (annotation points at .github line 21, not any test file).

Note: the original commit is missing Signed-off-by — please add it for DCO compliance (git commit --amend -s + force push, or use the GitHub DCO bot's instructions if available).

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e69516b9c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Skip pending env var merge for non-env extension types

getFinalEnvVars() always appends pendingEnvVar when it is non-empty, even if the env var section has been unmounted after switching formData.type away from stdio/streamable_http. In that flow, a user can type a pending env var, change type to sse, and submit; the hidden pending value is still sent to storeSecret even though createExtensionConfig for sse drops env keys, so the UI silently persists an orphaned secret that is not part of the saved extension config.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b56ebe2b2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Skip pending env var merge for non-env extension types

Guard the pending-env merge by formData.type before submit. As written, handleSubmit always calls getFinalEnvVars(), so a pending row typed under stdio/streamable_http can still be submitted after switching to sse (the env var UI unmounts but pendingEnvVar state is retained). This causes storeSecret to persist a secret that is not represented in the final extension config path for non-env types, creating orphaned config entries.

Useful? React with 👍 / 👎.