protocol cleanup by jamadeo · Pull Request #9147 · aaif-goose/goose

jamadeo · 2026-05-11T20:20:56Z

Clean up the ACP+ protocol a bit. Add a version tag to the custom methods and improve some types.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57bb146304

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

lifeizhou-ap · 2026-05-20T02:45:40Z


+/// Target scope for creating or importing sources.
+#[derive(Debug, Default, Clone, Serialize, Deserialize, JsonSchema)]
+#[serde(tag = "scope", rename_all = "camelCase")]


alexhancock

It looks good. I do think we should have a planned timeline on which we expect to progress things to stable, but that can come at another time.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 312fe12476

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-20T15:22:09Z

-  DefaultsReadRequest,
-  DefaultsReadResponse,
-  DefaultsSaveRequest,
+  AddConfigExtensionRequest_unstable,


Import existing unstable type aliases in generated client

client.gen.ts now imports snake-case symbols like AddConfigExtensionRequest_unstable, but types.gen.ts exports these as AddConfigExtensionRequestUnstable (PascalCase). That leaves most type imports unresolved, so the SDK package cannot type-check/build after regeneration.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-05-20T15:22:09Z

 ): Promise<void> {
  const client = await getClient();
-  await client.goose.GooseDictationModelSelect({ provider, modelId });
+  await client.goose.GooseDictationModelsSelect({ provider, modelId });


Call the generated unstable dictation select method

The regenerated SDK exposes GooseUnstableDictationModelsSelect, but this call uses GooseDictationModelsSelect, which is not present on client.goose. This causes a compile-time/property-missing failure (or runtime missing-function error) when saving dictation model selection.

Useful? React with 👍 / 👎.

jamadeo · 2026-05-20T15:22:45Z

It looks good. I do think we should have a planned timeline on which we expect to progress things to stable, but that can come at another time.

Yeah, 100% agree. If anything I think this encourages us to stabilize -- it makes the api uglier! But right now we have a consumer of ACP+ that isn't part of this repo, so we want to make sure these are able to break compatibility.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19292064db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-20T15:42:39Z

 function methodToCamelCase(method: string): string {
  return method
    .split(/[/_]/)
+    .filter((part) => part !== "v1")


Drop unstable segment from generated SDK method names

Keeping the unstable path segment in methodToCamelCase renames every generated method to GooseUnstable* (for example GooseUnstableSourcesCreate), but the rest of the tree still calls GooseSources*/GooseProviders* names (e.g. ui/goose2/src/features/skills/api/skills.ts and ui/sdk/scripts/check-binary-compat.mjs). That creates immediate missing-method compile/runtime failures after regeneration, so this change breaks the SDK consumers unless you either strip unstable during name generation or add compatibility aliases.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d00fa2fa71

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63890ed81d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-22T18:42:05Z

      const [configResp, sessionResp] = await Promise.all([
-        client.goose.GooseConfigExtensions({}),
-        client.goose.GooseSessionExtensions({sessionId}),
+        client.goose.GooseConfigExtensionsList({}),


Call the generated unstable extension methods

Fresh evidence in this commit: the regenerated SDK client (ui/sdk/src/generated/client.gen.ts) exposes configExtensionsList_unstable / sessionExtensionsList_unstable (and sessionExtensionsAdd/Remove_unstable), not Goose-prefixed methods like GooseConfigExtensionsList. Calling client.goose.GooseConfigExtensionsList here will fail with a missing-function error (and fails type-checking in typed consumers), so the TUI extensions screen cannot reliably load or manage session extensions.

Useful? React with 👍 / 👎.

* main: (48 commits) docs: stats update (#9410) Build summon instructions per turn (#9329) Fix desktop chat search session limiting (#9366) fix(agents): serialize per-session agent creation to stop duplicate MCP init (#9357) chore(deps): bump image from 0.24.9 to 0.25.10 (#9383) chore(deps): bump agent-client-protocol from 0.11.1 to 0.12.1 (#9381) chore(deps): bump ctor from 0.2.9 to 1.0.6 (#9380) chore(deps): bump strum from 0.27.2 to 0.28.0 (#9384) chore(deps): bump lru from 0.16.3 to 0.18.0 (#9382) chore(deps): bump shlex from 1.3.0 to 2.0.1 (#9379) chore(deps): bump sigstore-verify from 0.6.6 to 0.8.0 (#9378) chore(deps): bump clap_mangen from 0.2.33 to 0.3.0 (#9377) chore(deps): bump the cargo-minor-and-patch group with 12 updates (#9376) chore(deps): bump qs and express in /documentation (#9375) chore(deps): bump docker/build-push-action from 6.18.0 to 7.2.0 (#9374) chore(deps): bump step-security/harden-runner from 2.19.1 to 2.19.4 (#9373) chore(deps): bump EmbarkStudios/cargo-deny-action from 2.0.17 to 2.0.19 (#9372) chore(deps): bump actions/setup-python from 5 to 6 (#9371) chore(deps): bump actions-rust-lang/setup-rust-toolchain from 1.16.0 to 1.16.1 (#9370) protocol cleanup (#9147) ...

jamadeo added 2 commits May 11, 2026 15:57

protocol cleanup

826906b

Merge remote-tracking branch 'origin/main' into protocol-cleanup

57bb146

jamadeo marked this pull request as ready for review May 18, 2026 13:19

chatgpt-codex-connector Bot reviewed May 18, 2026

View reviewed changes

Comment thread ui/sdk/src/generated/client.gen.ts Outdated

Comment thread ui/sdk/src/generated/client.gen.ts Outdated

update callers

f4131c9

lifeizhou-ap reviewed May 20, 2026

View reviewed changes

lifeizhou-ap approved these changes May 20, 2026

View reviewed changes

jamadeo added 3 commits May 20, 2026 09:29

Merge remote-tracking branch 'origin/main' into protocol-cleanup

9754c41

use 'unstable'

b85adee

Add to method name

b5224dd

jamadeo force-pushed the protocol-cleanup branch from 8a82a74 to b5224dd Compare May 20, 2026 15:13

more references

312fe12

alexhancock approved these changes May 20, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed May 20, 2026

View reviewed changes

Fix the generators

1929206

chatgpt-codex-connector Bot reviewed May 20, 2026

View reviewed changes

client SDK names

d00fa2f

chatgpt-codex-connector Bot reviewed May 20, 2026

View reviewed changes

Comment thread ui/goose2/src/features/extensions/api/extensions.ts Outdated

Comment thread ui/goose2/src/features/chat/ui/McpAppView.tsx Outdated

jamadeo added this pull request to the merge queue May 20, 2026

github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 20, 2026

jamadeo added 2 commits May 22, 2026 14:35

Merge remote-tracking branch 'origin/main' into protocol-cleanup

31d5c9b

Merge remote-tracking branch 'origin/main' into protocol-cleanup

63890ed

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

jamadeo added this pull request to the merge queue May 22, 2026

jamadeo removed this pull request from the merge queue due to a manual request May 22, 2026

Update usages

8b3d264

jamadeo added this pull request to the merge queue May 22, 2026

Merged via the queue into main with commit 0a95821 May 22, 2026
22 checks passed

jamadeo deleted the protocol-cleanup branch May 22, 2026 21:11

github-actions Bot mentioned this pull request May 26, 2026

chore(release): release version 1.36.0 #9426

Closed

shafqatevo pushed a commit to shafqatevo/goose that referenced this pull request Aug 7, 2026

protocol cleanup (aaif-goose#9147)

d7dac7c

Uh oh!

Conversation

jamadeo commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

lifeizhou-ap May 20, 2026

Choose a reason for hiding this comment

Uh oh!

alexhancock left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 20, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot May 20, 2026

Choose a reason for hiding this comment

Uh oh!

jamadeo commented May 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 20, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alexhancock left a comment •

edited

Loading