feat: Hooks - #9093
Conversation
|
that seems nicer/crisper/cleaner than I thought! pretty cool |
a8cef11 to
56856ad
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56856ad32f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
56856ad to
6626ed7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6626ed7961
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
6626ed7 to
efed233
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efed2335d8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ) | ||
| .with_working_dir(session.working_dir.to_string_lossy().to_string()); | ||
| self.hook_manager | ||
| .emit(crate::hooks::HookEvent::PreToolUse, ctx) |
There was a problem hiding this comment.
PreToolUse would allow blocking tool execution, right? Is that something we'd come back to?
Looks like open-plugins itself doesn't specify, but I believe in Claude Code this is designed such that you could e.g. have a hook deny a tool call
There was a problem hiding this comment.
Interesting! Going to merge to take advantage of the green ci but will make a note to revisit in a future change
3 participants
Summary
Hooks support https://open-plugins.com/agent-builders/components/hooks
Testing
Manually tested with desktop via
just run-uiRelated Issues
N/A
Screenshots/Demos (for UX changes)