refactor: switch to official new rust-sdk for ACP - #9062
Merged
Conversation
jh-block
approved these changes
May 6, 2026
jh-block
left a comment
jh-block
left a comment
Collaborator
There was a problem hiding this comment.
I looked at the Cargo.toml changes and skimmed the rest, and my agent says it's fine. This is the kind of change that if it builds and runs I call it low risk, so 👍
jamadeo
approved these changes
May 6, 2026
lifeizhou-ap
added a commit
that referenced
this pull request
May 7, 2026
…-refactor * origin/main: refactor: switch to official new rust-sdk for ACP (#9062) refactor(goose2): remove attachment preamble (#9052) Align CODEOWNERS with pull request review rules in GOVERNANCE.md (#9056) bring MAINTAINERS.md up to date (#9053) feat(acp): expose built-in skills through sources list acp calls (#9045) add provider-first onboarding (#9039) feat: ACP streamable http spec compliance (#9034) Skip automatic fix which crashes (#9036) fix(openai): accept null tool_call arguments in streaming chunks (#9035) Signed-off-by: Lifei Zhou <lifei@squareup.com> # Conflicts: # ui/goose2/src/features/chat/hooks/useChat.ts
codefromthecrypt
left a comment
codefromthecrypt
left a comment
Collaborator
There was a problem hiding this comment.
thanks for the migration!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Tested with the TUI and via Zed locally
Related Issues
N/A
Screenshots/Demos (for UX changes)
N/A