keep settings open during window drag - #9018
Closed
morgmart wants to merge 1 commit into
Closed
Conversation
Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>
morgmart
marked this pull request as draft
May 5, 2026 18:45
Collaborator
Author
|
🤖 Closing this as superseded by the full-page Settings work in PR #9047. The drag-close bug lived in the old SettingsModal backdrop path; that modal no longer exists on the full-page settings branch, and Settings now renders inside the normal app shell/top bar drag region. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: Moving the app window while settings is open no longer closes settings unexpectedly.
Problem: The settings backdrop closed on any backdrop click, so a drag gesture outside the settings panel could be interpreted as a dismissal click. That made the app feel like it returned to Home when the user was only trying to move the window.
Solution: Split the backdrop into its own Tauri drag region behind the settings panel and make backdrop dismissal drag-aware. A normal backdrop click still closes settings, but pointer movement that looks like a window drag leaves settings open.
File changes
ui/goose2/src/features/settings/ui/SettingsModal.tsx
Adds drag-threshold handling for backdrop dismissal and isolates the Tauri drag region to the backdrop layer so settings controls do not become draggable window chrome.
ui/goose2/src/features/settings/ui/tests/SettingsModal.test.tsx
Adds regression coverage for normal backdrop click dismissal and drag-like pointer movement that should keep settings open.
Focused verification
pnpm --dir ui/goose2 exec vitest run src/features/settings/ui/__tests__/SettingsModal.test.tsxpnpm --dir ui/goose2 exec biome check src/features/settings/ui/SettingsModal.tsx src/features/settings/ui/__tests__/SettingsModal.test.tsxgit diff --checkFull goose2 pre-push/typecheck remains blocked by existing unrelated SDK definition mismatches on
mainsuch as missingGoosePreferencesRead,GooseDefaultsRead, andProviderConfigChangeResponseexports.Screenshots/Demos
Not captured in this pass.