Fix CRT linkage in Windows CUDA build - #8987
Merged
Merged
Conversation
jh-block
commented
May 4, 2026
jh-block
commented
Collaborator
- Upgrade candle to 0.10 which uses cudaforge instead of bindgen_cuda
- Use a patched cudaforge which respects the CRT linkage from cargo target features (PR has been submitted upstream)
- Remove forced-static-CRT rustflags (normal dynamic linkage can be used now)
Signed-off-by: jh-block <jhugo@block.xyz>
Signed-off-by: jh-block <jhugo@block.xyz>
Signed-off-by: jh-block <jhugo@block.xyz>
Signed-off-by: jh-block <jhugo@block.xyz>
Signed-off-by: jh-block <jhugo@block.xyz>
Signed-off-by: jh-block <jhugo@block.xyz>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d580371c86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: jh-block <jhugo@block.xyz>
DOsinga
approved these changes
May 4, 2026
lifeizhou-ap
added a commit
that referenced
this pull request
May 5, 2026
* main: align extensions page styling (#9003) fix: SACP notifies clients of generated session names (#8983) replace artifact heuristics/regexes with protocol messages (#8996) fold UI refactor review into code review skill (#8982) Improvements to LM Studio declarative provider (#8973) chore(deps): bump dawidd6/action-download-artifact from 12 to 21 (#8959) chore(deps): bump azure/login from 2.3.0 to 3.0.0 (#8957) chore(deps): bump actions/github-script from 8.0.0 to 9.0.0 (#8956) chore(deps): bump dependabot/fetch-metadata from 2.3.0 to 3.1.0 (#8955) Fix CRT linkage in Windows CUDA build (#8987) # Conflicts: # ui/goose2/src/features/chat/stores/chatSessionStore.ts # ui/goose2/src/shared/api/acpNotificationHandler.ts
shafqatevo
pushed a commit
to shafqatevo/goose
that referenced
this pull request
Aug 7, 2026
Signed-off-by: jh-block <jhugo@block.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.