fix: unscheduling a recipe should not delete them - #8978
Merged
Conversation
Signed-off-by: Angie Jones <jones.angie@gmail.com>
angiejones
changed the title
michaelneale
approved these changes
May 4, 2026
michaelneale
left a comment
michaelneale
left a comment
Collaborator
There was a problem hiding this comment.
I think makes sense - seems odd that it would also delete recipe (maybe that was by design but is surprising which I assume is why you want to change this, so makes sense to change behavior to be less surprising!)
lifeizhou-ap
approved these changes
May 4, 2026
lifeizhou-ap
left a comment
lifeizhou-ap
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @angiejones for the fix and making the behaviour consistent!
Collaborator
Author
yeah, bit me twice 😭 figured I should put in a fix |
shafqatevo
pushed a commit
to shafqatevo/goose
that referenced
this pull request
Aug 7, 2026
Signed-off-by: Angie Jones <jones.angie@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unscheduling a recipe also deletes the underlying recipe file, making the workflow unrecoverable.
This fix only removes the schedule.
Added a test as well.