fix: respect goose2 interface density settings - #8953
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8f160306a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
morgmart
approved these changes
May 1, 2026
morgmart
force-pushed
the
kalvin/goose2-interface-density
branch
from
May 1, 2026 20:56
e8f1603 to
a08e986
Compare
morgmart
enabled auto-merge
May 1, 2026 21:03
shafqatevo
pushed a commit
to shafqatevo/goose
that referenced
this pull request
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: Users can now change Goose 2 interface density and have spacing update immediately and persist across reloads.
Problem: Goose 2 exposed interface density controls, but the saved preference did not reliably affect the actual spacing tokens used by the UI. Invalid saved theme, accent, or density values could also leak into the theme state instead of falling back to defaults.
Solution: The theme layer now validates persisted preferences, applies density through a root
data-densityattribute, and lets CSS own the compact and spacious spacing tokens so the UI reflects the selected density consistently.File changes
ui/goose2/index.html
Applies a saved compact or spacious density before the app renders. This prevents the initial page load from showing the default spacing before React mounts.
ui/goose2/src/features/settings/ui/tests/AppearanceSettings.test.tsx
Adds coverage for changing interface density from the appearance settings controls. The test verifies the selected value persists and updates the document root state.
ui/goose2/src/shared/styles/globals.css
Defines CSS density tokens for compact and spacious layouts. This keeps spacing behavior in the stylesheet where the UI tokens are consumed.
ui/goose2/src/shared/theme/ThemeProvider.test.tsx
Expands theme provider coverage for persisted density, invalid persisted values, accent fallback behavior, and the expected CSS density definitions.
ui/goose2/src/shared/theme/ThemeProvider.tsx
Validates persisted theme, accent, and density preferences before using them. Density changes now update the root density attribute instead of setting spacing variables inline.
Reproduction Steps
Screenshots/Demos
Demo: Settings > Appearance > Interface Density now updates Compact, Comfortable, and Spacious spacing states and preserves the selected state across reloads.
density.mov