add encrypted Nostr session sharing by callebtc · Pull Request #8922 · aaif-goose/goose

callebtc · 2026-04-29T23:03:51Z

Overview

Category: new-feature
User Impact: Users can share and import Goose conversations through encrypted Nostr links instead of manually exchanging exported JSON files.
Problem: Session export already supports JSON files but leaves users to manage transport themselves. There was also no direct way for a receiving Goose client to fetch and restore a shared conversation from a link.
Solution: Add an isolated Nostr sharing layer that encrypts the session JSON with NIP-44 v2, publishes it as kind 30278 to configurable relays, and encodes the event reference plus decryption key in a Goose deep link. The CLI, server API, and desktop session UI now reuse that path for exporting, importing, and handling Nostr session deep links.

Changes

File changes

Cargo.lock
Adds the Nostr SDK, NIP-44 crypto, relay-pool, and supporting dependency graph needed to publish and fetch encrypted Nostr events.

crates/goose/Cargo.toml
Adds nostr, nostr-sdk, and an optional rustls dependency wired into the existing rustls-tls feature so the live Nostr client can install a Rustls crypto provider.

crates/goose/src/session/mod.rs
Exports the new isolated nostr_share module from the session domain.

crates/goose/src/session/nostr_share.rs
Implements the reusable core Nostr share/import logic: default/configured relays, NIP-44 v2 encryption/decryption, kind 30278 event creation, nevent encoding, Goose deep-link creation, live publish/fetch clients, and unit tests.

crates/goose-cli/src/cli.rs
Adds CLI flags for goose session export --format json --nostr --relay ... and a new goose session import command that accepts either JSON files or Nostr share links.

crates/goose-cli/src/commands/session.rs
Wires CLI export/import to the shared Nostr module while preserving the existing JSON/YAML/Markdown export behavior.

crates/goose-server/src/routes/session.rs
Adds desktop-facing endpoints for sharing a session to Nostr and importing a Nostr share link back through the normal session import path.

crates/goose-server/src/openapi.rs
Registers the new Nostr session endpoints and schemas in the OpenAPI spec.

ui/desktop/openapi.json
Regenerates the desktop OpenAPI schema with the new Nostr share/import endpoints.

ui/desktop/src/api/index.ts
Regenerates the desktop API exports so UI code can call the new Nostr endpoints.

ui/desktop/src/api/sdk.gen.ts
Regenerates typed API client functions for importSessionNostr and shareSessionNostr.

ui/desktop/src/api/types.gen.ts
Regenerates request/response types for Nostr session import and share responses.

ui/desktop/src/components/sessions/SessionListView.tsx
Adds desktop UI controls to create encrypted Nostr share links from session cards and import a pasted Goose Nostr share link from Chat History.

ui/desktop/src/sessionLinks.ts
Routes goose://sessions/nostr?... deep links through the Nostr import endpoint before returning users to the session list.

Reproduction Steps

Start Goose Desktop and create or use an existing chat session.
Open Chat History and hover a session card.
Click the Nostr share icon to publish the encrypted session event and show a copyable goose://sessions/nostr?... link.
Use Chat History's Import Link button and paste that link.
Confirm the session is fetched from the relays, decrypted, imported, and appears in the session list.
From the CLI, run goose session export --session-id <id> --format json --nostr and verify it prints a Goose Nostr share link.
From another Goose client, run goose session import '<goose://sessions/nostr?...>' and verify it imports the session.

Validation

cargo fmt
cargo test -p goose nostr_share --lib
cargo test -p goose-cli parses_session_export_nostr_relays --lib
cargo test -p goose-cli parses_session_import_nostr_link --lib
cargo check -p goose-server
pnpm run generate-api
pnpm run typecheck

callebtc · 2026-04-29T23:07:27Z

CLI:

GUI:

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c4c3eaa8c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: callebtc <93376500+callebtc@users.noreply.github.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7ef2cf3a6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-29T23:45:31Z

+      await importSessionNostr({
+        body: { deeplink: url },
+        throwOnError: true,
+      });


Handle Nostr deep-link errors in the sessions flow

importSessionNostr is called inside the shared try block, so any Nostr import failure (invalid link, relay fetch/decrypt error, server-side 400/500) falls through to the generic catch path that always navigates to the shared-session error view. That view is specific to share-token links and shows an irrelevant shareToken for goose://sessions/nostr URLs, which breaks the intended import flow for failed Nostr links. Split Nostr handling/error routing from legacy shared-session handling so Nostr failures stay in the sessions import UX.

Useful? React with 👍 / 👎.

# Conflicts: # Cargo.lock

- Merge origin/main and resolve conflicts - Fix Nostr deep link routing: separate from shared-session flow so Nostr imports navigate to /sessions and errors show a toast instead of the irrelevant shared-session error view (addresses Codex P1/P2) - Remove dead 'rustls' feature flag (rustls-tls already covers it) - Change ShareSessionNostrRequest.relays from Option<Vec> to Vec with serde default (avoid unnecessary Option) - Fix clipboard copy error using wrong i18n message (importFailed) - Remove trivial CLI arg-parsing tests (just testing clap) - Regenerate openapi.json Signed-off-by: Douwe Osinga <douwe@squareup.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b167989639

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-12T19:30:52Z

+          await importNostrSessionFromDeepLink(link);
+          navigate('/sessions');
+          return;


Reload session list after Nostr deep-link import

After a successful goose://sessions/nostr import this path only calls navigate('/sessions'), but SessionListView fetches sessions only on mount (useEffect(() => { loadSessions(); }, [loadSessions])). If the user is already on /sessions when the deep link arrives, the list component stays mounted and no refresh runs, so the newly imported conversation does not appear until a manual reload or later action. Trigger a sessions refresh (or navigate with a state signal that forces reload) after import success.

Useful? React with 👍 / 👎.

DOsinga

Approving this PR. The code is well-structured — clean trait abstractions for testability, proper NIP-44 v2 encryption with ephemeral keys, and good round-trip tests.

I've pushed a fix commit that:

Merges origin/main and resolves conflicts
Fixes the Nostr deep link routing (Codex P1/P2): Nostr imports now navigate to /sessions with errors shown as toasts, instead of falling through to the shared-session error view
Removes the dead standalone rustls feature flag (rustls-tls already covers it)
Changes ShareSessionNostrRequest.relays from Option<Vec<String>> to Vec<String> with #[serde(default)]
Fixes clipboard copy error using wrong i18n message
Removes trivial CLI arg-parsing tests (just testing clap)
Regenerates openapi.json

DCO: @callebtc your commits are missing Signed-off-by lines which will fail the DCO check. Please amend your commits with git commit --amend -s or rebase with git rebase --signoff.

michaelneale · 2026-05-12T23:13:08Z

oh this is really exciting @callebtc ! (it is like you were listening to @DOsinga and myself chatting in a room a few weeks back!) - taking a look, I love this idea.

Signed-off-by: Michael Neale <michael.neale@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d07b40892

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-13T02:29:19Z

+        if (link.startsWith('goose://sessions/nostr')) {
+          await importNostrSessionFromDeepLink(link);
+          navigate('/sessions');


Redact Nostr deep-link secrets from logs

When this Nostr branch handles an OS deep link, it has already logged the full link a few lines above; these new Nostr URLs include the key query parameter that is sufficient to decrypt the shared session. Anyone with access to desktop logs or diagnostics could recover the encrypted conversation, so redact the key value or log only the link type before handling Nostr imports.

Useful? React with 👍 / 👎.

a little over dramatic 🙄 - a log on the disk for a session which is in sessions.db in sql lite.. on the same disk (!) so ... that is silly

michaelneale · 2026-05-13T02:31:31Z

I am updating this, got one more change to go and then will merge it in... thanks.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 363962180b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-13T02:51:32Z

      setSharedSessionError(null);
      try {
+        if (link.startsWith('goose://sessions/nostr')) {
+          await importNostrSessionFromDeepLink(link);


Guard Nostr imports against duplicate deep-link delivery

In the Windows/Linux launch path I checked ui/desktop/src/main.ts: processProtocolUrl sends open-shared-session for sessions links without clearing pendingDeepLink, and the later react-ready handler sends the same pending link again. With this new branch, each delivery calls the Nostr import endpoint and SessionManager::import_session creates a fresh session, so a single OS goose://sessions/nostr?... link can produce duplicate imported conversations. Make the Nostr import path idempotent or dedupe/clear the pending link before importing.

Useful? React with 👍 / 👎.

Signed-off-by: callebtc <93376500+callebtc@users.noreply.github.com> Signed-off-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: Michael Neale <michael.neale@gmail.com> Co-authored-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: Michael Neale <michael.neale@gmail.com>

callebtc added 4 commits April 29, 2026 13:54

add nostr-based session import / export to CLI

22e2123

share works

2b6ddaf

nice

f0083a5

add nostr import / export to GUI

6c4c3ea

chatgpt-codex-connector Bot reviewed Apr 29, 2026

View reviewed changes

Comment thread ui/desktop/src/sessionLinks.ts Outdated

update desktop i18n messages

d7ef2cf

Signed-off-by: callebtc <93376500+callebtc@users.noreply.github.com>

chatgpt-codex-connector Bot reviewed Apr 29, 2026

View reviewed changes

Douwe Osinga added 2 commits May 12, 2026 14:58

Merge remote-tracking branch 'origin/main' into nostr-export

18a7b72

# Conflicts: # Cargo.lock

DOsinga added the needs_human label to set when a robot looks at a PR and can't handle it label May 12, 2026

chatgpt-codex-connector Bot reviewed May 12, 2026

View reviewed changes

DOsinga assigned michaelneale May 12, 2026

DOsinga approved these changes May 12, 2026

View reviewed changes

Merge origin/main into nostr-export

4d07b40

Signed-off-by: Michael Neale <michael.neale@gmail.com>

chatgpt-codex-connector Bot reviewed May 13, 2026

View reviewed changes

show/hide nostr and also redact key

3639621

chatgpt-codex-connector Bot reviewed May 13, 2026

View reviewed changes

michaelneale added this pull request to the merge queue May 13, 2026

Merged via the queue into aaif-goose:main with commit dbbee1c May 13, 2026
22 checks passed

github-actions Bot mentioned this pull request May 20, 2026

chore(release): release version 1.35.0 #9346

Closed

BrewTestBot mentioned this pull request Jul 2, 2026

block-goose-cli 1.40.0 Homebrew/homebrew-core#290949

Merged

BrewTestBot mentioned this pull request Aug 12, 2026

block-goose-cli 1.46.0 Homebrew/homebrew-core#298471

Merged

Uh oh!

Conversation

callebtc commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Changes

Reproduction Steps

Validation

Uh oh!

callebtc commented Apr 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 12, 2026

Choose a reason for hiding this comment

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

michaelneale commented May 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 13, 2026

Choose a reason for hiding this comment

Uh oh!

michaelneale May 13, 2026

Choose a reason for hiding this comment

Uh oh!

michaelneale commented May 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

callebtc commented Apr 29, 2026 •

edited

Loading