feat(ui): add codex intelligence selector - #8919
Conversation
Co-Authored-By: goose <goose@aaif.dev> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e1f390315
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4f50ae0de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ce816b6a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
|
Thanks for the PR! The code looks clean and follows existing patterns well. One concern: this adds another provider-specific thinking control to the UI, which is already getting fragmented (Claude thinking type/effort/budget, Gemini thinking level, and now Codex intelligence). There was a prior attempt to unify all of these into a single control in #7628 that was abandoned. Could you have a look at that PR and see if you think that unified approach is the way to go here? It would be great to solve this once for all providers rather than adding another one-off. |
|
I believe this is obviated by #9242, which unifies the setting across providers. Feel free to re-open if that PR doesn't address this. Thank you! |
Summary
CHATGPT_CODEX_REASONING_EFFORTlow,medium,high, andxhighfor known Codex models; fallback tomedium/highotherwiseReview Notes
Test plan
pnpm run lint:checkpnpm run test:runCHATGPT_CODEX_REASONING_EFFORT