Skip to content

feat(ui): add codex intelligence selector - #8919

Closed
vincenzopalazzo wants to merge 4 commits into
aaif-goose:mainfrom
vincenzopalazzo:feat/chatgpt-codex-intelligence
Closed

feat(ui): add codex intelligence selector#8919
vincenzopalazzo wants to merge 4 commits into
aaif-goose:mainfrom
vincenzopalazzo:feat/chatgpt-codex-intelligence

Conversation

@vincenzopalazzo

Copy link
Copy Markdown
Contributor

Summary

  • Add an Intelligence selector for ChatGPT Codex in the desktop model switch modal
  • Persist the selected value to CHATGPT_CODEX_REASONING_EFFORT
  • Match backend-supported levels: low, medium, high, and xhigh for known Codex models; fallback to medium/high otherwise
  • Add extracted i18n messages for the new labels

Review Notes

  • Production-safety review passed (2 clean rounds)
  • This reuses the existing ChatGPT Codex provider config path added for reasoning effort; no server/OpenAPI changes needed
  • Kept the scope global-config based, matching the current provider implementation

Test plan

  • pnpm run lint:check
  • pnpm run test:run
  • CI passes
  • Manual: select ChatGPT Codex in the model switch modal and confirm the Intelligence selector persists to CHATGPT_CODEX_REASONING_EFFORT

Co-Authored-By: goose <goose@aaif.dev>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e1f390315

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui/desktop/src/components/settings/models/subcomponents/SwitchModelModal.tsx Outdated
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f4f50ae0de

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui/desktop/src/components/settings/models/subcomponents/SwitchModelModal.tsx Outdated
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ce816b6a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui/desktop/src/components/settings/models/subcomponents/SwitchModelModal.tsx Outdated
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@DOsinga

DOsinga commented May 12, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR! The code looks clean and follows existing patterns well.

One concern: this adds another provider-specific thinking control to the UI, which is already getting fragmented (Claude thinking type/effort/budget, Gemini thinking level, and now Codex intelligence). There was a prior attempt to unify all of these into a single control in #7628 that was abandoned.

Could you have a look at that PR and see if you think that unified approach is the way to go here? It would be great to solve this once for all providers rather than adding another one-off.

@DOsinga DOsinga added the needs_human label to set when a robot looks at a PR and can't handle it label May 12, 2026
@jamadeo

jamadeo commented May 27, 2026

Copy link
Copy Markdown
Member

I believe this is obviated by #9242, which unifies the setting across providers. Feel free to re-open if that PR doesn't address this. Thank you!

@jamadeo jamadeo closed this May 27, 2026
@vincenzopalazzo
vincenzopalazzo deleted the feat/chatgpt-codex-intelligence branch May 27, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs_human label to set when a robot looks at a PR and can't handle it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants