feat: support google model inventory refresh - #8913
Merged
Merged
Conversation
Add Google provider support for ACP inventory refresh so goose2 validates saved Google API keys through the existing model-listing flow. Handle non-success responses from the Google models endpoint before parsing the response body, allowing invalid API keys to surface the provider error instead of a missing models array error.
kalvinnchau
changed the title
lifeizhou-ap
added a commit
that referenced
this pull request
Apr 30, 2026
* main: (24 commits) fix: copy and content improvements in goose2 (#8886) feat: make ollama host configurable in goose2 (#8912) polish sidebar navigation and project icons (#8896) fix: model picker stays usable during provider loading (#8900) feat: update provider row after saving credentials (#8914) feat: support google model inventory refresh (#8913) chore: Added goose 2 UI refactor review skill (#8903) blog: goose with peekaboo (#8884) blog: Built-in Local Inference blogpost. (#8808) perf: parallelize provider resolution and eagerly init SQLite pool (#8899) refactor: update goose2 credential management behind provider-scoped ACP/core API (#8887) fix: handle acp requests concurrently (#8781) build: set LLAMA_STATIC_CRT for Windows CUDA (#8901) perf: deduplicate _goose/providers/list RPC call at startup (#8873) chore: add a bit more instructions in the release pr (#8890) chore: disable spellcheck in model search (#8889) add skills to the chat composer (#8881) mergeable configs + cleanup (#8378) refactor: agent provider to use explicit type states (#8879) [goose2] MCP Apps: hydrate and replay app payloads in Goose2 (#8632) ...
shafqatevo
pushed a commit
to shafqatevo/goose
that referenced
this pull request
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: Users setting up Google Gemini in goose2 now see model refresh and API key errors handled consistently with other providers.
Problem: Google Gemini credentials could be saved in goose2 without triggering the provider inventory refresh used by other model providers. Invalid Google API keys also produced a misleading missing models array error because the models response was parsed before checking the HTTP status.
Solution: Enable inventory refresh for the Google provider and include the relevant host/API key in its inventory identity. The Google model listing path now maps non-success responses before parsing the model list, so invalid keys surface the provider's actual error.
File changes
crates/goose/src/providers/google.rs
Adds Google provider support for ACP inventory refresh and identifies inventory entries by
GOOGLE_HOSTandGOOGLE_API_KEY. Updates model listing to handle non-success responses before parsing themodelsarray, matching the behavior users expect from other providers.Reproduction Steps
modelsarray message.