Skip to content

chore: disable spellcheck in model search #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kalvinnchau merged 1 commit into from
Apr 29, 2026
Merged

chore: disable spellcheck in model search #8889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions ui/goose2/src/features/chat/ui/AgentModelPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { useProviderInventoryStore } from "@/features/providers/stores/providerI
import { cn } from "@/shared/lib/cn";
import { Button } from "@/shared/ui/button";
import { Popover, PopoverContent, PopoverTrigger } from "@/shared/ui/popover";
import { SearchBar } from "@/shared/ui/SearchBar";
import { ScrollArea } from "@/shared/ui/scroll-area";
import { Spinner } from "@/shared/ui/spinner";
import {
Expand Down Expand Up @@ -244,17 +245,14 @@ function AllModelsList({
>
<IconChevronLeft className="size-4" />
</button>
<div className="relative min-w-0 flex-1">
<IconSearch className="pointer-events-none absolute left-2 top-1/2 size-3.5 -translate-y-1/2 text-muted-foreground" />
<input
ref={inputRef}
type="text"
value={query}
onChange={(e) => setQuery(e.target.value)}
placeholder={t("toolbar.searchModels")}
className="h-7 w-full rounded-sm border bg-transparent pl-7 pr-2 text-sm outline-none placeholder:text-muted-foreground focus:ring-1 focus:ring-ring"
/>
</div>
<SearchBar
inputRef={inputRef}
size="small"
value={query}
onChange={setQuery}
placeholder={t("toolbar.searchModels")}
className="min-w-0 flex-1"
/>
</div>
{filtered.length > 0 ? (
<ScrollArea className="min-h-0 min-w-0 flex-1">
Expand Down
28 changes: 28 additions & 0 deletions ui/goose2/src/features/chat/ui/__tests__/AgentModelPicker.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,34 @@ describe("AgentModelPicker", () => {
expect(longModelButton).toHaveClass("overflow-hidden");
});

it("disables spellcheck in the all-models search field", async () => {
const user = userEvent.setup();

render(
<AgentModelPicker
agents={AGENTS}
selectedAgentId="goose"
onAgentChange={vi.fn()}
currentModelId="claude-sonnet-4"
currentModelName="Claude Sonnet 4"
availableModels={[
{ id: "claude-sonnet-4", name: "Claude Sonnet 4", recommended: true },
{ id: "gpt-4o-mini-2024-07-18", name: "GPT-4o mini" },
]}
onModelChange={vi.fn()}
/>,
);

await user.click(
screen.getByRole("button", { name: /choose agent and model/i }),
);
await user.click(screen.getByRole("button", { name: "Browse all models" }));

const search = screen.getByPlaceholderText("Search models...");

expect(search).toHaveAttribute("spellcheck", "false");
});

it("shows only agent name when no model info is available", () => {
render(
<AgentModelPicker
Expand Down
Loading