fix: removed failed provider test for deprecated providers#8801
Conversation
lifeizhou-ap
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ffc6132b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: "gpt-5.3-codex", | ||
| reasoning_levels: &["low", "medium", "high", "xhigh"], | ||
| }, | ||
| ChatGptCodexModelAttrs { | ||
| name: "gpt-5.2-codex", | ||
| reasoning_levels: &["low", "medium", "high", "xhigh"], | ||
| }, | ||
| ChatGptCodexModelAttrs { | ||
| name: "gpt-5.1-codex", | ||
| reasoning_levels: &["low", "medium", "high", "xhigh"], | ||
| }, | ||
| ChatGptCodexModelAttrs { | ||
| name: "gpt-5.1-codex-mini", | ||
| reasoning_levels: &["medium", "high"], | ||
| }, | ||
| ChatGptCodexModelAttrs { | ||
| name: "gpt-5.1-codex-max", | ||
| reasoning_levels: &["low", "medium", "high", "xhigh"], | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
By truncating CHATGPT_CODEX_KNOWN_MODELS to only gpt-5.4 and gpt-5.3-codex, configurations that still use gpt-5.2-codex/gpt-5.1-* now fall through reasoning_levels_for_model to the default medium/high set, so previously valid values like low or xhigh get silently coerced to medium in get_reasoning_effort. This changes runtime behavior for existing users without any explicit migration or validation failure.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Those legacy gpt-5.2-codex / gpt-5.1-* models are no longer supported for chatgpt_codex, so we should stop supporting them. For existing session with gpt-5.2-codex (which does not work anyway), switching to gpt-5.4 works.
* main: (29 commits) chore(deps): bump winreg from 0.55.0 to 0.56.0 (#8829) Fix grammar issue (#8669) colorize context window indicator (#8851) Refresh canonical model metadata from models.dev (#8838) fix(ci): prevent flaky smoke test timeouts from failing the build (#8837) updates: release 0.19.0 of the tui/sdk/etc (#8806) add a goose2 signed release flow (#8728) Port provider tests to typescript (#8237) refactor: make ACP server smaller (#8787) Add NVIDIA provider, and improve declarative provider UX (#8798) fix: removed failed provider test for deprecated providers (#8801) fix: only call cleanup when the pr is from same repo (#8799) chore: check stale for draft pr (#8803) fix: use _meta instead of meta in newSession request (#8796) fix: add missing underscore prefix in updateWorkingDir method name (#8743) feat: migrate session metadata storage from frontend overlay to backend (#8769) Add more info to BUILDING_LINUX (#8789) feat(acp): Align to new request patterns of ACP Streamable HTTP/WS transport (#8605) Dedupe and organize skills/sources (#8731) docs: add skills slash command (#8783) ...
2 participants
Summary
Testing
CI
Related Issues
Relates to #ISSUE_ID
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
After: