fix: use python3 in developer extension instructions for macOS/Linux compatibility - #8784
Conversation
…compatibility Modern macOS (12+) and many Linux distributions no longer ship a `python` binary, only `python3`. The developer extension instructions now explicitly tell the model to use `python3` when running Python scripts or commands. Fixes aaif-goose#8756 Signed-off-by: Treebird <treebird@treebird.dev>
c4eb813 to
77503e4
Compare
The snapshot for test_all_platform_extensions was not updated alongside the developer_instructions() change. Update it to include the two new python3 guidance lines so the test passes. Signed-off-by: Treebird <treebird@treebird.dev>
| Use write and edit to efficiently make changes. Test and verify as appropriate. | ||
|
|
||
| When running Python scripts or commands, always use `python3` instead of `python`. | ||
| The `python` command is not available on modern macOS and many Linux distributions. |
There was a problem hiding this comment.
I think the second sentence can be removed; it doesn't shape model behaviour and wastes tokens.
There was a problem hiding this comment.
Smart thinking, deleted that sentence.
Update documentation to specify using 'python3' command.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa77451276
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Use write and edit to efficiently make changes. Test and verify as appropriate. | ||
|
|
||
| When running Python scripts or commands, always use `python3` instead of `python`. | ||
| The `python` command is not available on modern macOS and many Linux distributions. |
There was a problem hiding this comment.
This snapshot now expects The python command is not available on modern macOS and many Linux distributions. even though developer_instructions() only adds the preceding python3 sentence in crates/goose/src/agents/platform_extensions/developer/mod.rs and never emits this second line. As a result, prompt_manager::tests::test_all_platform_extensions will fail on non-Windows targets when assert_snapshot! compares generated output to this stale expectation.
Useful? React with 👍 / 👎.
Remove unnecessary information about the 'python' command.
|
looks good but there's a test failure, looks like whitespace in a snapshot |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* main: feat: move goose2 provider catalog behind ACP layer (#9030) fix: use python3 in developer extension instructions for macOS/Linux compatibility (#8784) fix(acp): synchronously reap ACP child to avoid SIGCHLD race (#9023) fix goose2 small-window chat and settings layouts (#9019) docs: improve goose2 AGENTS.md (#9028) agents: add CLAUDE.mds to mirror AGENTS.mds (#9029) remove skill categories (#9008) fix: 8531 - elicitation fixes (#8999) feat(chat): group consecutive tool calls into one summarized chain card (#8995) fix(ci): mark openai/gpt-5 smoke test as flaky (#9027) goose2 distribution bundling (#8911) Add "Trimmed trailing whitespace" message to moim whitelist (#8847)
…compatibility (aaif-goose#8784) Signed-off-by: Treebird <treebird@treebird.dev> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2 participants
Summary
Modern macOS (12+) removed the
pythonbinary — onlypython3is available.Many Linux distributions follow the same convention. When the model uses the
developer extension to run Python scripts, it may invoke
pythondirectly,which fails on these systems.
This adds a clear instruction to the non-Windows developer extension system
prompt to always use
python3instead ofpython.Testing
developer_instructions()— testsin mod.rs are functional tool-call tests (shell, write, edit)
cfg!(windows)elsebranch, so Windows behaviour is unaffected
Related Issues
Relates to #8756