Skip to content

fix: removed hardcoded dependency of goose-acp-macro #8753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamadeo merged 2 commits into from
Apr 22, 2026
Merged

fix: removed hardcoded dependency of goose-acp-macro #8753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa68f0
removed hardcoded dependency
lifeizhou-ap Apr 22, 2026
ce2cd9b
update rustls-webpki 0.103.12 → 0.103.13 to apply security patch RUST…
lifeizhou-ap Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/goose/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ pem = { version = "3", optional = true }
pkcs1 = { version = "0.7", default-features = false, features = ["pkcs8"], optional = true }
pkcs8 = { version = "0.10", default-features = false, features = ["alloc"], optional = true }
sec1 = { version = "0.7", default-features = false, features = ["der", "pkcs8"], optional = true }
goose-acp-macros = { version = "1.31.0", path = "../goose-acp-macros" }
goose-acp-macros = { path = "../goose-acp-macros" }
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add version requirement to goose-acp-macros path dependency

Removing the version from this path dependency makes crates/goose fail Cargo packaging checks, so release/publish workflows that package this crate will now break. I verified this in this repo with cargo package -p goose --allow-dirty --no-verify, which errors that all dependencies must have a version requirement and specifically flags goose-acp-macros; keeping a semver requirement (or workspace-managed equivalent) avoids that regression while still allowing local path resolution.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

@lifeizhou-ap lifeizhou-ap Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t currently use cargo package/cargo publish in this repo, so that packaging concern isn’t actionable for our workflow.

The issue we were actually hitting was canary/release version rewriting, where the hardcoded goose-acp-macros = "1.31.0" could drift from the workspace version. This also matches existing internal dependency usage here: other crates already use path-only internal deps like goose-sdk, goose-mcp, and goose in goose-cli/goose-server.

Copy link
Copy Markdown
Member

@jamadeo jamadeo Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, if you revert it and try that cargo package command, it just fails on the next workspace dependency. This objection makes no sense

tower-http = { workspace = true, features = ["cors"] }
http-body-util = "0.1.3"

Expand Down
Loading