-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: lazy init local inference runtime in router instead of app start #8656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bab91e8
added more logging to debug
lifeizhou-ap 1025586
fixed check
lifeizhou-ap 2c9073e
remove unnessary logs
lifeizhou-ap ed7e889
init local inference runtime in the route instead of startup
lifeizhou-ap 701435b
added doc
lifeizhou-ap 7e7d443
address review comments
lifeizhou-ap 31bbb67
refactor
lifeizhou-ap 6792440
return error when init local inference rather than panic
lifeizhou-ap 29e578e
frontend improvement
lifeizhou-ap aed2b17
Merge branch 'main' into lifei/logging-whne-start-error
lifeizhou-ap 40cf7ec
Merge branch 'main' into lifei/logging-whne-start-error
lifeizhou-ap 4ce5a65
Merge branch 'main' into lifei/logging-whne-start-error
lifeizhou-ap File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit adds
boot_marker(...)calls on the normal success path, sogoosednow writes manyGOOSED_BOOTlines to stderr even when nothing is wrong. That violates the logging rule in/workspace/goose/AGENTS.md(only add logs for errors/security), and it also degrades desktop triage becauseui/desktop/src/goosed.tscollects stderr into startup error diagnostics. Please guard these markers behind an explicit debug flag or a trace-level logger so production stderr stays signal-only.Useful? React with 👍 / 👎.