Register IconTheme in OpenAPI schema after rmcp 1.5.0 upgrade#8621
Merged
Conversation
The rmcp 1.5.0 upgrade added an IconTheme enum to the Icon struct, but the type was not registered in the OpenAPI schema definitions. This caused openapi-ts code generation to fail with: Reference not found: #/components/schemas/IconTheme Add IconTheme import, derive its utoipa schema, and register it alongside the existing Icon schema. Regenerate openapi.json and TypeScript API types. Signed-off-by: jh-block <jhugo@block.xyz>
lifeizhou-ap
approved these changes
Apr 17, 2026
Signed-off-by: jh-block <jhugo@block.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: CI and local builds no longer fail when generating the OpenAPI schema and TypeScript API types.
Problem: The rmcp 1.5.0 upgrade (merged in #8618) added an
IconThemeenum field to theIconstruct, butIconThemewas never registered in the OpenAPI schema definitions. This causedopenapi-tscode generation to fail withReference not found: #/components/schemas/IconTheme, breakingjust check-openapi-schemain CI and locally.Solution: Import
IconTheme, derive its utoipa schema, and register it in the OpenAPI schema list alongside the existingIconschema. Regenerateopenapi.jsonand the TypeScript API types.File changes
crates/goose-server/src/openapi.rs
Import
IconThemefrom rmcp, addderive_utoipa!(IconTheme as IconThemeSchema), and registerIconThemeSchemain the#[openapi(schemas(...))]attribute so the generated OpenAPI spec includes the missing type.ui/desktop/openapi.json
Regenerated schema now includes the
IconThemeenum definition and thethemefield onIcon.ui/desktop/src/api/types.gen.ts
Regenerated TypeScript types now include the
IconThemetype and thethemeproperty on theIconinterface.ui/desktop/src/api/index.ts
Regenerated barrel export updated to include
IconTheme.How to verify
just check-openapi-schema— it should pass with "✅ OpenAPI schema is up-to-date".just generate-openapi— it should complete without errors.