chore: move acp to sdk#8556
Conversation
alexhancock
force-pushed
the
alexhancock/ui-acp-sdk-renames
branch
from
54e3572 to
9a2c099
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54e3572a65
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| echo "==> Publishing @aaif/goose-sdk" | ||
| (cd "${REPO_ROOT}/ui" && pnpm publish "${PUBLISH_ARGS[@]}" acp) |
There was a problem hiding this comment.
This step still invokes pnpm publish ... acp even though the package directory was moved to ui/sdk; pnpm publish expects its positional argument to be a <tarball>|<dir>, so this now fails with ERR_PNPM_NO_IMPORTER_MANIFEST_FOUND for acp and stops the release flow before the SDK publish can run. Point this command at sdk (or use an explicit package filter/name) to keep the publish script functional after the rename.
Useful? React with 👍 / 👎.
2 participants
Summary
Some missed renames and moving a dir