call goose serve from tauri frontend via goose-acp client by lifeizhou-ap · Pull Request #8549 · aaif-goose/goose

lifeizhou-ap · 2026-04-15T09:40:58Z

Summary

Calling goose serve via web socket from tauri frontend

Why

Tauri IPC doesn't stream natively, but the browser does
Frontend does not tie to Tauri, can be portable to other web clients
We can reuse the goose acp client

Changes

Move ACP protocol handling from Rust Tauri backend to TypeScript
Frontend talks directly to goose serve over WebSocket, bypassing the Rust middleware
Controlled by feature flag (USE_DIRECT_ACP)
functions in acp.ts wired through the new path using USE_DIRECT_ACP feature flag
Old Rust path still works when flag is off

TODO

Cleanup and remove the feature toggle
ui/acp (@aaif/goose-acp) upgrades to be compatible with @agentclientprotocol/sdk@0.19.0 (latest version)
goose serve includes messageId on each ContentChunk notification
move create websocket stream logic to @aaif/goose-acp

Testing

Manual

Related Issues

Relates to #ISSUE_ID
Discussion: LINK (if any)

Screenshots/Demos (for UX changes)

Before:

After:

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2cee286d7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-15T09:48:46Z

+  const existing = prepared.get(key) ?? prepared.get(sessionId);
+  if (existing) {
+    return existing.gooseSessionId;


Reconcile provider before reusing prepared ACP sessions

prepareSession returns an existing prepared session unconditionally, even when the caller passes a different providerId. In direct ACP mode this means provider switches in the UI are ignored for already-prepared sessions, so prompts can execute on the old/default provider and model updates can fail due to provider/model mismatch.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-15T09:48:46Z

+  if (USE_DIRECT_ACP) {
+    return directAcp.setModel(sessionId, modelId);


Set model using the mapped Goose session ID

In direct mode acpSetModel sends the local UI sessionId directly, but drafts and persona-scoped sessions may be backed by a different Goose session ID created in prepareSession. When those IDs differ, model updates target a non-existent ACP thread and the send flow fails before prompting.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-15T09:48:46Z

+  if (USE_DIRECT_ACP) {
+    await directAcp.cancelSession(sessionId);


Cancel direct ACP prompts via tracked session mapping

acpCancelSession ignores the tracked local→Goose session mapping (and the passed personaId) and cancels using the local sessionId. For draft/persona streams where the ACP session ID differs, stop requests report success but the backend generation continues and keeps streaming chunks.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4c917a0a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-15T10:16:37Z

+    await directAcp.loadSession(gooseSessionId, effectiveWorkingDir);
+    sessionTracker.registerSession(sessionId, gooseSessionId, "goose", effectiveWorkingDir);


Register session mapping before loading replay

In direct ACP mode this function registers the local→Goose session mapping after loadSession resolves, but replay notifications are handled during loadSession. The notification handler resolves IDs via getLocalSessionId(gooseSessionId) ?? gooseSessionId, so when sessionId and gooseSessionId differ (the acpSessionId path used in AppShell), replay chunks are routed to the wrong session key and history can load into the wrong thread or appear missing. Bind/register the mapping before invoking directAcp.loadSession.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-15T10:16:37Z

+  if (USE_DIRECT_ACP) {
+    return directAcp.exportSession(sessionId);


Resolve Goose session ID before direct export

The direct branch exports using the UI-local sessionId, but prepareSession can create a different Goose session ID via newSession and store that only in acpSessionTracker. For newly promoted draft chats, this makes Session History export fail with "not found" until sessions are reloaded from ACP. Look up the mapped Goose ID (or persisted acpSessionId) before calling exportSession.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42abb685ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-15T10:32:52Z

+    const response = await acpApi.newSession(workingDir);
+    gooseSessionId = response.sessionId;


Set provider on newly created direct ACP sessions

When prepareSession falls back to newSession, the requested providerId is never applied before returning, yet the tracker caches that provider as if it were active. On first-send from a new draft (or any unmapped session), prompts can run on Goose’s default provider and model selection can fail if the selected model belongs to another provider. Apply the provider immediately after newSession (or pass provider metadata into session creation) before storing the prepared entry.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-15T10:32:52Z

          ? resolveEffectiveWorkingDir(null, await getHomeDir())
          : undefined);
      await acpLoadSession(sessionId, gooseSessionId, workingDir);
+      useChatStore.getState().setSessionLoading(sessionId, false);


Keep replay mode active until load notifications are drained

Clearing loadingSessionIds immediately after acpLoadSession resolves can terminate replay buffering before all replay notifications arrive. In direct ACP mode, loadSession returns from the RPC call without an explicit replay-complete handshake in this path, so late chunks are processed as live events (or dropped by live-stream guards), which can produce missing/truncated history when opening a session.

Useful? React with 👍 / 👎.

For direct ACP, I don’t think this is a real issue. I traced the raw websocket traffic for session/load and saw the expected ACP ordering: replay session/update notifications arrived before the matching session/load response, and no replay updates arrived after the response.

In this path, await acpLoadSession(...) is the completion boundary handled by the ACP SDK’s request/response lifecycle, so clearing loadingSessionIds after it resolves is consistent with the acp spec.

chatgpt-codex-connector · 2026-04-15T10:32:52Z

  sessionId: string,
 ): Promise<AcpSessionInfo> {
+  if (USE_DIRECT_ACP) {
+    return directAcp.forkSession(sessionId);


Resolve Goose session ID before direct duplicate

The direct duplicate path forks using the UI-local sessionId instead of the tracked Goose session ID. For sessions created via newSession (where local and Goose IDs differ), this sends forkSession to a non-existent backend session and duplicate fails until a full reload rehydrates IDs. Use acpSessionTracker (or persisted acpSessionId) before invoking forkSession.

Useful? React with 👍 / 👎.

jamadeo · 2026-04-15T17:18:28Z

    "test-driver": "tsx tests/app-e2e/lib/test-driver-cli.ts"
  },
  "dependencies": {
+    "@aaif/goose-acp": "^0.16.0",


this should probably be "@aaif/goose-sdk": "workspace:*",, assuming the pnpm workspace is all set up correctly here

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 257f9fdf00

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-16T07:34:21Z

+    const messageId = crypto.randomUUID();
+    setActiveMessageId(gooseSessionId, messageId);
+
+    await directAcp.prompt(gooseSessionId, content);


Apply provider before direct prompt dispatch

The direct ACP branch sends prompt without reconciling providerId, so this path can run on a stale backend provider when the session was previously prepared under a different provider. This is reachable because useChat only calls acpPrepareSession for drafts or when a model ID is present, so provider changes on existing sessions can skip re-prepare and still hit this call, producing responses from the wrong provider/model combination.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-16T07:34:21Z

+  try {
+    await acpApi.loadSession(sessionId, workingDir);
+    gooseSessionId = sessionId;
+  } catch {}


Restrict new-session fallback to not-found load errors

This swallows all loadSession failures and immediately creates a new session, which can silently fork history when the failure is transient (connection drop, backend error, invalid cwd) rather than “session not found.” In those cases users can be moved to a fresh thread with lost continuity instead of seeing the real error, so the fallback should only trigger for explicit not-found responses.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-16T07:34:21Z

+      const exported = await exportSession(sessionId);
+      const result = searchSession(sessionId, exported, trimmed);
+      if (result) results.push(result);
+    } catch {
+      // skip sessions that fail to export


Translate local IDs before export-based session search

Search exports each provided sessionId directly and silently skips failures, but direct ACP keeps local→Goose remapping in acpSessionTracker for promoted draft/persona sessions. When callers pass local IDs (e.g., sessions without persisted acpSessionId yet), exports fail and those sessions are omitted from search results until a reload rehydrates IDs, causing incomplete or inconsistent search behavior.

Useful? React with 👍 / 👎.

…l-placeholder * origin/main: (64 commits) fix: expand tool calls by default when Response Style is Detailed (aaif-goose#8478) fix: create logs dir before writing llm request log (aaif-goose#8522) fix: enable token usage tracking and configurable stream timeout for Ollama provider (aaif-goose#8493) fix tauri-plugin-dialog version constraint to match other plugins (aaif-goose#8542) call goose serve from tauri frontend via goose-acp client (aaif-goose#8549) failed the script when bundle:default fails and cleanup "alpha" (aaif-goose#8580) pass globally unique conversation identifier as sessionId in databricks api call (aaif-goose#8576) fix: use sqlx chrono decode for thread timestamps instead of manual parsing (aaif-goose#8575) docs: remove stale gemini-acp references (aaif-goose#8572) show individual untracked files in git changes widget (aaif-goose#8574) fix: update publishing flow to include new sdk dir (aaif-goose#8573) fix: remove double border on content in chat (aaif-goose#8545) chore(goose2): `just goose2 <command>` with the addition of `just goose2 kill` (aaif-goose#8570) Lifei/oltp data (aaif-goose#8458) Sidebar polish: search copy, dividers, project reorder, fix DnD (aaif-goose#8568) remove the workflow_dispatch check (aaif-goose#8563) fix: one more rename (aaif-goose#8562) fix(desktop): accept self-signed certs from configured external goosed host (aaif-goose#8400) alexhancock/npm-bumps (aaif-goose#8557) Remove npm publish from release for now (aaif-goose#8558) ...

* main: (37 commits) polish: refine sidebar activity indicators, add placeholder token, and tidy search field (#8606) feat: add /edit command to cli for on-demand prompt editing (#8566) docs(mcp): add Rendex MCP Server extension tutorial (#8541) Lifei/delete tauri backend acp (#8582) chore: set goose binaries as executable in package.json (#8589) feat: add Novita AI as declarative provider (#8432) feat: add Kimi Code provider with OAuth device flow authentication (#8466) fix: chat loading-state model placeholder (#8431) fix: expand tool calls by default when Response Style is Detailed (#8478) fix: create logs dir before writing llm request log (#8522) fix: enable token usage tracking and configurable stream timeout for Ollama provider (#8493) fix tauri-plugin-dialog version constraint to match other plugins (#8542) call goose serve from tauri frontend via goose-acp client (#8549) failed the script when bundle:default fails and cleanup "alpha" (#8580) pass globally unique conversation identifier as sessionId in databricks api call (#8576) fix: use sqlx chrono decode for thread timestamps instead of manual parsing (#8575) docs: remove stale gemini-acp references (#8572) show individual untracked files in git changes widget (#8574) fix: update publishing flow to include new sdk dir (#8573) fix: remove double border on content in chat (#8545) ...

jamadeo and others added 13 commits April 14, 2026 12:43

Make a plan

b5ce250

websocket transport

caeb1fe

clean up

937ee4a

add command to get goose binary url and add acp npm packages

38fafe5

creae acp client

86a170b

fixed protocol version

e2eabd3

created acp api to wrap goose client to call goose serve

bc6e203

turned non streaming api to be called from tauri frontend directly

dd2a9d3

enabled more apis

d973081

fixing a few things for send message

8eff14b

set loading to false

e0c33f2

session search from frontend

c57d694

fixed resume session

2cee286

chatgpt-codex-connector Bot reviewed Apr 15, 2026

View reviewed changes

added missing logic and acp call

d4c917a

chatgpt-codex-connector Bot reviewed Apr 15, 2026

View reviewed changes

Fixed ci

42abb68

chatgpt-codex-connector Bot reviewed Apr 15, 2026

View reviewed changes

set provider

ac47265

jamadeo approved these changes Apr 15, 2026

View reviewed changes

lifeizhou-ap added 2 commits April 16, 2026 17:17

address review comments

5095bda

fix style check

257f9fd

lifeizhou-ap enabled auto-merge April 16, 2026 07:28

lifeizhou-ap added this pull request to the merge queue Apr 16, 2026

chatgpt-codex-connector Bot reviewed Apr 16, 2026

View reviewed changes

Merged via the queue into main with commit 50ac3dc Apr 16, 2026
24 checks passed

lifeizhou-ap deleted the lifei/goose-serve-from-tauri-frontend branch April 16, 2026 07:41

tulsi-builder mentioned this pull request Apr 16, 2026

feat(goose2): voice dictation via direct-ACP pattern #8609

Merged

6 tasks

tulsi-builder mentioned this pull request Apr 16, 2026

feat: wire up voice dictation in goose2 via ACP #8565

Closed

github-actions Bot mentioned this pull request Apr 23, 2026

chore(release): release version 1.32.0 #8764

Closed

		if (USE_DIRECT_ACP) {
		return directAcp.setModel(sessionId, modelId);

		if (USE_DIRECT_ACP) {
		await directAcp.cancelSession(sessionId);

		await directAcp.loadSession(gooseSessionId, effectiveWorkingDir);
		sessionTracker.registerSession(sessionId, gooseSessionId, "goose", effectiveWorkingDir);

		if (USE_DIRECT_ACP) {
		return directAcp.exportSession(sessionId);

		const response = await acpApi.newSession(workingDir);
		gooseSessionId = response.sessionId;

Conversation

lifeizhou-ap commented Apr 15, 2026

Summary

Why

Changes

TODO

Testing

Related Issues

Screenshots/Demos (for UX changes)

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

lifeizhou-ap Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

jamadeo Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants