removed unused welcome route#8196
Merged
Merged
Conversation
DOsinga
approved these changes
Mar 30, 2026
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
Clean removal of the dead /welcome route — all references consistently removed across routing, navigation utils, main process, and tests. Test updates correctly assert the OnboardingGuard behavior. LGTM!
michaelneale
added a commit
that referenced
this pull request
Mar 30, 2026
* origin/main: removed unused welcome route (#8196) fix: use build_host_url for GCP Vertex AI location fallback (#8185) fix: remove ui/acp/.npmrc to allow auth token inheritance fix(openai): use safely_parse_json for streaming tool arguments (#8208) feat: add copilot-acp provider (#8154) chore(deps): bump path-to-regexp from 8.3.0 to 8.4.0 in /evals/open-model-gym/mcp-harness (#8178) fix: add NODE_AUTH_TOKEN and always-auth (#8163) fix: i18n compile on windows (#8202)
lifeizhou-ap
added a commit
that referenced
this pull request
Apr 1, 2026
* origin/main: (85 commits) docs: standardize on ~/.agents/skills/ as canonical skill path (#8239) feat: bump versions (already published) (#8240) Revert "fix: rename bin for the tui (#8231)" (#8238) docs: update reusable recipes docs (#8232) docs: add GOOSE_SHELL env var (#8233) feat(security): add egress logging inspector (#8149) blog: Adversary Mode — A Second Pair of Eyes on Every Tool Call (#8220) fix: rename bin for the tui (#8231) feat: goose serve (#8209) refactor: make --text mode independent of the normal TUI (#8210) refactor: handle complex streaming/scrolling with better rendering (#8214) Add Inference Mesh settings tab (#8094) only run windows compile on main branch (#8216) used simplified privacy info modal and removed unnecessary components (#8200) removed unused welcome route (#8196) fix: use build_host_url for GCP Vertex AI location fallback (#8185) fix: remove ui/acp/.npmrc to allow auth token inheritance fix(openai): use safely_parse_json for streaming tool arguments (#8208) feat: add copilot-acp provider (#8154) chore(deps): bump path-to-regexp from 8.3.0 to 8.4.0 in /evals/open-model-gym/mcp-harness (#8178) ... # Conflicts: # ui/desktop/.gitignore # ui/desktop/src/components/Layout/CondensedRenderer.tsx # ui/desktop/src/components/Layout/navigation/ChatSessionsDropdown.tsx # ui/desktop/src/components/Layout/navigation/SessionsList.tsx # ui/desktop/src/components/ParameterInputModal.tsx # ui/desktop/src/components/parameter/ParameterInput.tsx # ui/desktop/src/components/recipes/RecipeActivityEditor.tsx # ui/desktop/src/components/recipes/shared/CreateSubRecipeInline.tsx # ui/desktop/src/main.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code cleanup
Testing
Unit test