actions: various pnpm publishing flow fixes#8112
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22a557e688
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| paths: | ||
| - 'crates/goose-acp/**' | ||
| - 'ui/acp/**' | ||
| - '.github/workflows/publish-npm.yml' | ||
| - '.github/workflows/build-native-packages.yml' |
There was a problem hiding this comment.
Expand push path filters to include all publishable packages
The new on.push.paths filter only matches crates/goose-acp/**, ui/acp/**, and workflow files, so pushes to main that change other published workspace packages (for example ui/text/** or ui/goose-acp-server/**) will no longer trigger this release workflow. Since this workflow still builds ui/text and runs changeset publish from ui, those package updates can be skipped indefinitely unless someone manually dispatches the workflow.
Useful? React with 👍 / 👎.
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Fixes four things with the in progress pnpm based publishing flow for the new TUI
Publish to npmon irrelevantmainpushesenvironmentgate on thePublish to npmworkflow for the time being, so we can let the job run. Publishing will still not be able to occur, as theNPM_PUBLISH_TOKENis only available onmainAll syntax now passes actionlint, and we will be able to run the full job (minus the part that actually does a working publish) on branches now