Skip to content

actions: various pnpm publishing flow fixes#8112

Merged
alexhancock merged 1 commit into
mainfrom
alexhancock/pnpm-publish-flow
Mar 25, 2026
Merged

actions: various pnpm publishing flow fixes#8112
alexhancock merged 1 commit into
mainfrom
alexhancock/pnpm-publish-flow

Conversation

@alexhancock
Copy link
Copy Markdown
Collaborator

Fixes four things with the in progress pnpm based publishing flow for the new TUI

All syntax now passes actionlint, and we will be able to run the full job (minus the part that actually does a working publish) on branches now

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22a557e688

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +16 to +20
paths:
- 'crates/goose-acp/**'
- 'ui/acp/**'
- '.github/workflows/publish-npm.yml'
- '.github/workflows/build-native-packages.yml'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Expand push path filters to include all publishable packages

The new on.push.paths filter only matches crates/goose-acp/**, ui/acp/**, and workflow files, so pushes to main that change other published workspace packages (for example ui/text/** or ui/goose-acp-server/**) will no longer trigger this release workflow. Since this workflow still builds ui/text and runs changeset publish from ui, those package updates can be skipped indefinitely unless someone manually dispatches the workflow.

Useful? React with 👍 / 👎.

@alexhancock alexhancock merged commit 5b4dd40 into main Mar 25, 2026
21 checks passed
@alexhancock alexhancock deleted the alexhancock/pnpm-publish-flow branch March 25, 2026 14:05
vincenzopalazzo pushed a commit to vincenzopalazzo/goose that referenced this pull request Mar 26, 2026
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants