Fix Flatpak sandbox preventing access to host system commands#8109
Conversation
vincenzopalazzo
force-pushed
the
macros/debugging
branch
from
03f4b51 to
f32dc4b
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f32dc4b9fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
vincenzopalazzo
force-pushed
the
macros/debugging
branch
from
f32dc4b to
e82d94e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e82d94e09d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
vincenzopalazzo
force-pushed
the
macros/debugging
branch
from
e82d94e to
144e94e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b38c22c8d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 449572b3b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 600c158776
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
vincenzopalazzo
force-pushed
the
macros/debugging
branch
from
5de1d8f to
b3ab76e
Compare
vincenzopalazzo
requested review from
DOsinga,
angiejones and
blackgirlbytes
as code owners
vincenzopalazzo
force-pushed
the
macros/debugging
branch
from
b3ab76e to
ff94d1f
Compare
Run developer shell commands on the Flatpak host instead of inside the sandbox. Preserve the intended shell resolution and add host process lifecycle handling so timed-out commands do not outlive Goose. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/debugging
branch
from
ff94d1f to
cab4057
Compare
|
Hi @DOsinga, is there anything left in this PR to unlock it |
Signed-off-by: Douwe Osinga <douwe@squareup.com>
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
Looks good. Legitimate fix for Flatpak sandbox issue (#7986), from an established contributor (7 merged PRs). All Codex review comments were addressed. Merged main and removed the trivial flatpak_spawn_command_uses_watch_bus test (it only asserted a constant equals itself). Build, clippy, fmt, and all shell tests pass.
2 participants
Summary
/usr/binshows nfsnobody-owned sandbox binaries)configure_shell_commandspawns commands using the sandbox's shell directly/.flatpak-infoand wrap commands withflatpak-spawn --host, forwarding environment variables via--envargs and resolving shells by basename for host PATH lookupFixes #7986
Test plan
ls -l /usr/binshows host system binaries with correct ownership.flatpak-infoabsent, code takes existing path)get_unix_path_asyncreturns host paths when in Flatpak🤖 Generated with Claude Code