Skip to content

fix: clarify that sandbox functions are only callable via execute_typescript#8096

Merged
DOsinga merged 1 commit into
aaif-goose:mainfrom
dale-lakes:fix/clarify-execute-only-functions
Mar 25, 2026
Merged

fix: clarify that sandbox functions are only callable via execute_typescript#8096
DOsinga merged 1 commit into
aaif-goose:mainfrom
dale-lakes:fix/clarify-execute-only-functions

Conversation

@dale-lakes
Copy link
Copy Markdown
Contributor

@dale-lakes dale-lakes commented Mar 25, 2026

The MOIM info-msg lists sandbox functions (Todo.todoWrite, Autovisualiser.renderMermaid, etc.) as "Available functions" with no indication they can't be called directly. Models attempt direct tool calls, which fail with -32002: Tool not found.

Uses is_first_class_extension() to filter the function list. Extensions with unprefixed_tools=true (Developer, Analyze) have their tools registered as direct top-level tools and are excluded from the sandbox-only label. Only functions from non-first-class extensions are labeled as execute_typescript-only.

@dale-lakes dale-lakes marked this pull request as draft March 25, 2026 00:56
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 29c50c39b8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread crates/goose/src/agents/platform_extensions/code_execution.rs Outdated
@dale-lakes dale-lakes force-pushed the fix/clarify-execute-only-functions branch from 29c50c3 to a886301 Compare March 25, 2026 00:59
@dale-lakes dale-lakes changed the title fix: separate direct tools from sandbox-only functions in MOIM prompt fix: clarify that sandbox functions are only callable via execute_typescript Mar 25, 2026
@dale-lakes dale-lakes marked this pull request as ready for review March 25, 2026 01:11
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a88630108e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread crates/goose/src/agents/platform_extensions/code_execution.rs Outdated
Use is_first_class_extension() to filter the function list. Extensions
with unprefixed_tools=true (Developer, Analyze) have their tools
registered as direct top-level tools — listing them as sandbox-only
would incorrectly suppress valid direct calls.

Only functions from non-first-class extensions (Todo, Autovisualiser,
Memory, etc.) are labeled as execute_typescript-only.

Signed-off-by: Dale Lakes <6843636+spitfire55@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@dale-lakes dale-lakes force-pushed the fix/clarify-execute-only-functions branch from a886301 to 6b2b092 Compare March 25, 2026 01:26
@DOsinga DOsinga added this pull request to the merge queue Mar 25, 2026
Merged via the queue into aaif-goose:main with commit 70003c2 Mar 25, 2026
21 checks passed
vincenzopalazzo pushed a commit to vincenzopalazzo/goose that referenced this pull request Mar 26, 2026
…escript (aaif-goose#8096)

Signed-off-by: Dale Lakes <6843636+spitfire55@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants