Skip to content

fix: use pnpm when publishing #8092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexhancock merged 1 commit into from
Mar 24, 2026
Merged

fix: use pnpm when publishing #8092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/publish-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ jobs:
node-version: '20'
registry-url: 'https://registry.npmjs.org'

- name: Setup pnpm
uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # v4
with:
version: 9

- name: Setup Rust
uses: dtolnay/rust-toolchain@631a55b12751854ce901bb631d5902ceb48146f7 # stable

Expand Down Expand Up @@ -86,15 +91,15 @@ jobs:
- name: Install dependencies
run: |
cd ui
npm ci
pnpm install --frozen-lockfile
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Narrow pnpm install to release workspaces

Running pnpm install --frozen-lockfile at ui/ now installs the entire workspace, which includes ui/desktop where engines requires Node ^24.10.0 and pnpm >=10.30.0 (ui/desktop/package.json lines 6-9). In this workflow we still pin Node 20 and pnpm 9, so this step fails with ERR_PNPM_UNSUPPORTED_ENGINE before any package build/publish can run; this is a regression introduced by switching from npm ci to workspace-wide pnpm install.

Useful? React with 👍 / 👎.


- name: Build packages
run: |
cd ui/acp
npm run build
pnpm run build

cd ../text
npm run build
pnpm run build

- name: Dry run summary
if: inputs.dry-run == true || github.ref != 'refs/heads/main'
Expand All @@ -121,8 +126,8 @@ jobs:
id: changesets
uses: changesets/action@6d3568c53fbe1db6c1f9ab1c7fbf9092bc18627f # v1
with:
publish: npm run release
version: npm run version
publish: pnpm run release
version: pnpm run version
commit: 'chore: version packages'
title: 'chore: version packages'
cwd: ui
Expand Down
Loading