Skip to content

fix the ink version#8003

Closed
michaelneale wants to merge 1 commit into
mainfrom
micn/ink-version
Closed

fix the ink version#8003
michaelneale wants to merge 1 commit into
mainfrom
micn/ink-version

Conversation

@michaelneale
Copy link
Copy Markdown
Collaborator

@michaelneale michaelneale commented Mar 19, 2026

needs a new version and react, so that it is actually usable in iterm2

edit: #8004 may be better of the 2 as it uses stdio (on top of this) FWY

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 81def905f6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread ui/text/package.json
"@agentclientprotocol/sdk": "^0.14.1",
"@block/goose-acp": "^0.1.0",
"ink": "^5.1.0",
"ink": "^6.8.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Declare Ink 6's new Node 20 requirement

Upgrading ink here silently raises the TUI's runtime floor from Node 18 to Node 20: the updated workspace lockfile resolves ink@6.8.0 with engines.node: >=20, whereas the previous ink@5.x worked on Node 18, and neither ui/text/package.json nor the install docs (ui/text/README.md, documentation/docs/guides/acp-clients.md) advertise a stricter engine. Users on Node 18/19 who could previously run cd ui/text && npm install && npm start will now end up with an unsupported dependency tree, so we should either keep Ink 5 or explicitly enforce/document the new Node requirement alongside this version bump.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant