fix: emit user-facing message on compaction failure#7975
Merged
jh-block merged 1 commit intoaaif-goose:mainfrom Mar 19, 2026
Merged
fix: emit user-facing message on compaction failure#7975jh-block merged 1 commit intoaaif-goose:mainfrom
jh-block merged 1 commit intoaaif-goose:mainfrom
Conversation
When compaction fails, the user sees "Compacting to continue conversation..." with a thinking indicator, then the stream ends with no follow-up. The user is left with a stalled thinking spinner and no indication that compaction failed. Emit a message explaining the failure and suggesting they retry or start a new session. Change-Id: Id65286bc0adbb143d7ed71856a4ffb9837836cff Signed-off-by: Rabi Mishra <mishra.rabi@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3847fb848a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
jh-block
approved these changes
Mar 19, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This was referenced Mar 20, 2026
cloorc
pushed a commit
to LeafAI/Leaf-ARC
that referenced
this pull request
Mar 20, 2026
Signed-off-by: Rabi Mishra <mishra.rabi@gmail.com>
cloorc
pushed a commit
to LeafAI/Leaf-ARC
that referenced
this pull request
Mar 20, 2026
Signed-off-by: Rabi Mishra <mishra.rabi@gmail.com>
9 tasks
elijahsgh
pushed a commit
to elijahsgh/goose
that referenced
this pull request
Mar 21, 2026
Signed-off-by: Rabi Mishra <mishra.rabi@gmail.com> Signed-off-by: esnyder <elijah.snyder1@gmail.com>
elijahsgh
pushed a commit
to elijahsgh/goose
that referenced
this pull request
Mar 21, 2026
Signed-off-by: Rabi Mishra <mishra.rabi@gmail.com> Signed-off-by: esnyder <elijah.snyder1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When compaction fails, the user sees "Compacting to continue conversation..." with a thinking indicator, then the stream ends with no follow-up. The user is left with a stalled thinking spinner and no indication that compaction failed.
Emit a message explaining the failure and suggesting they retry or start a new session.