Support CodeMode ToolDisclosure Variants#7926
Merged
Merged
Conversation
Signed-off-by: Elias Posen <elias@posen.ch>
Signed-off-by: Elias Posen <elias@posen.ch>
Signed-off-by: Elias Posen <elias@posen.ch>
Signed-off-by: Elias Posen <elias@posen.ch>
Signed-off-by: Elias Posen <elias@posen.ch>
Signed-off-by: Elias Posen <elias@posen.ch>
eliasposen
requested review from
DOsinga,
angiejones and
blackgirlbytes
as code owners
Signed-off-by: Elias Posen <elias@posen.ch>
eliasposen
commented
Mar 16, 2026
| let full_name = tool.name.to_string(); | ||
| let (namespace, name) = if let Some((server, tool_name)) = full_name.split_once("__") { | ||
| (server.to_string(), tool_name.to_string()) | ||
| let (name, namespace) = if let Some((prefix, tool_name)) = tool.name.split_once("__") { |
Contributor
Author
There was a problem hiding this comment.
Interested if someone can confirm this is the correct prioritization to discern the extension name/tool name?
Signed-off-by: Elias Posen <elias@posen.ch>
jh-block
approved these changes
Mar 16, 2026
| } | ||
| } | ||
|
|
||
| pub fn get_tool_disclosure() -> ToolDisclosure { |
Collaborator
There was a problem hiding this comment.
This should use the config system, e.g.:
let config = crate::config::Config::global();
let style_env: String = config
.get_param("CODE_MODE_TOOL_DISCLOSURE")
.unwrap_or_else(|_| "catalog".to_string());
Signed-off-by: Elias Posen <elias@posen.ch>
Signed-off-by: Elias Posen <elias@posen.ch>
Signed-off-by: Elias Posen <elias@posen.ch>
Contributor
Author
|
@angiejones I believe this PR needs sign-off from one of your team as there is a small |
DOsinga
approved these changes
Mar 18, 2026
This was referenced Mar 20, 2026
cloorc
pushed a commit
to LeafAI/Leaf-ARC
that referenced
this pull request
Mar 20, 2026
Signed-off-by: Elias Posen <elias@posen.ch>
cloorc
pushed a commit
to LeafAI/Leaf-ARC
that referenced
this pull request
Mar 20, 2026
Signed-off-by: Elias Posen <elias@posen.ch>
9 tasks
elijahsgh
pushed a commit
to elijahsgh/goose
that referenced
this pull request
Mar 21, 2026
Signed-off-by: Elias Posen <elias@posen.ch> Signed-off-by: esnyder <elijah.snyder1@gmail.com>
elijahsgh
pushed a commit
to elijahsgh/goose
that referenced
this pull request
Mar 21, 2026
Signed-off-by: Elias Posen <elias@posen.ch> Signed-off-by: esnyder <elijah.snyder1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pctx@0.3.0introducedToolDisclosurevariants that allow for different sets of tools to be exposed when the code execution extension is active. You can read a summary of the variants here.ToolDisclosurecan be configured via theCODE_MODE_TOOL_DISCLOSUREenv var, defaulting toToolDisclosure::Catalog(same as before this PR).Other updates:
pctx_code_modecrateType of Change
AI Assistance
Testing
Related Issues
Relates to #ISSUE_ID
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
After: