-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Separate SSE streaming from POST work submission #7834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
f6a9043
feat: separate SSE event streaming from POST work submission
jh-block 51123aa
style: cargo fmt
jh-block 6bdbd83
fix: move sessionSseClient out of generated api/ directory
jh-block 3dd3130
refactor: use generated SSE client for session events endpoint
jh-block 77f3421
fix: remove unnecessary onFinish from useCallback dependency arrays
jh-block b9c5454
chore: regenerate API client after rebase onto main
jh-block 2732eed
fix: address code review feedback on SSE event bus
jh-block dd8a59d
fix: route notification events correctly and clamp replay seq
jh-block 97cdf70
fix: replay buffered events on first SSE connect and clean up event b…
jh-block 3620e5d
chore: regenerate API client after rebase onto main
jh-block 06b2d51
fix: subscribe before snapshot to prevent event gaps, close lagged st…
jh-block d935222
fix: cancel requests against the session that started them
jh-block 6a52e0e
fix: abort in-flight reply POST when user clicks stop
jh-block a1d1709
fix: reconnect SSE stream after normal server-side EOF
jh-block 6868e07
fix: preserve Last-Event-ID across SSE reconnects
jh-block d0afb53
fix: clear request listeners on session change
jh-block 734d486
fix: reject cancel/events requests for unknown sessions
jh-block f1d689c
fix: validate session exists before queuing reply work
jh-block a4ed0bd
Merge remote-tracking branch 'origin/main' into jhugo/fix-sse-reconne…
jh-block 1592f9f
fix: address CI lint failures
jh-block b2668f2
Merge remote-tracking branch 'origin/main' into jhugo/fix-sse-reconne…
jh-block 0615808
fix: cancel in-flight replies on session delete and cap SSE retries
jh-block f52cdc7
fix: assign event sequence under lock and keep SSE reconnecting
jh-block 27a52e4
fix: set sseMaxRetryAttempts so SSE errors surface to outer loop
jh-block 2688b30
fix: detect replay buffer overflow and reload conversation
jh-block 6da2476
fix: defer SSE connected state, use getSession for reload, avoid erro…
jh-block 418cb63
feat: reattach to in-flight replies after remounting the chat view
jh-block c6406f5
fix: send ActiveRequests before replay and without SSE id
jh-block 4093cf6
fix: guard ref cleanup on request ID and preserve replayed output
jh-block 9529590
style: cargo fmt
jh-block db31581
fix: preserve transcript on cold-mount reattach and clear stale errors
jh-block 2834228
fix: buffer events during cold-mount reattach and guard POST cleanup
jh-block File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ mod error; | |
| mod logging; | ||
| mod openapi; | ||
| mod routes; | ||
| mod session_event_bus; | ||
| mod state; | ||
| mod tunnel; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.