Skip to content

fix(apps): declare color-scheme to allow transparent MCP App iframes #7479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aharvard merged 2 commits into from
Feb 24, 2026
Merged

fix(apps): declare color-scheme to allow transparent MCP App iframes #7479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a095f3a
fix(apps): declare color-scheme to allow transparent MCP App iframes
aharvard Feb 24, 2026
60008bb
fix: set colorScheme to 'light' in fallback paths
aharvard Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/goose-server/src/routes/templates/mcp_app_proxy.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<head>
<meta charset="utf-8"/>
<meta name="referrer" content="no-referrer"/>
<meta name="color-scheme" content="light dark"/>
<!--
The Content Security Policy is dynamically created by Rust at request time based on the domains declared in the MCP App's resource metadata.
-->
Expand Down
10 changes: 10 additions & 0 deletions ui/desktop/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,30 @@

if (isDark) {
document.documentElement.classList.add('dark');
document.documentElement.style.colorScheme = 'dark';
} else {
document.documentElement.classList.remove('dark');
document.documentElement.style.colorScheme = 'light';
}
} else {
const systemPrefersDark = window.matchMedia('(prefers-color-scheme: dark)').matches;
if (systemPrefersDark) {
document.documentElement.classList.add('dark');
document.documentElement.style.colorScheme = 'dark';
} else {
document.documentElement.classList.remove('dark');
document.documentElement.style.colorScheme = 'light';
}
}
Comment thread
aharvard marked this conversation as resolved.
} catch (error) {
console.warn('Failed to initialize theme from localStorage, using system preference:', error);
const systemPrefersDark = window.matchMedia('(prefers-color-scheme: dark)').matches;
if (systemPrefersDark) {
document.documentElement.classList.add('dark');
document.documentElement.style.colorScheme = 'dark';
Comment thread
aharvard marked this conversation as resolved.
} else {
document.documentElement.classList.remove('dark');
document.documentElement.style.colorScheme = 'light';
}
}
}
Expand Down
1 change: 1 addition & 0 deletions ui/desktop/src/contexts/ThemeContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ function applyThemeToDocument(theme: ResolvedTheme): void {
const toRemove = theme === 'dark' ? 'light' : 'dark';
document.documentElement.classList.add(theme);
document.documentElement.classList.remove(toRemove);
document.documentElement.style.colorScheme = theme;
}

// Built once — light-dark() values are theme-independent
Expand Down
Loading