Add lmstudio declarative provider and fix up a few rough edges#7454
Closed
Add lmstudio declarative provider and fix up a few rough edges#7454
Conversation
Contributor
Author
|
Closing for more investigation / testing, will put up a separate PR for just the declarative provider changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added LM Studio as a built-in provider for Goose so its easier to setup. Also fixed several issues
that made the local model experience poor.
PROBLEMS:
that silently broke ALL declarative provider loading (Groq, DeepSeek, Cerebras, Mistral, Inception, OVHcloud all disappeared from the UI)
exceeded), users saw cryptic "Failed to parse streaming chunk: missing field
choices" instead of the actual error message from the server
raw tags and thinking content leaked into both chat messages and session names
kept reusing the broken session instead of creating a fresh one
FIXES:
no auth, dynamic model fetching)
declarative providers
all providers
non-standard error responses embedded in streams
content and emits it as proper Reasoning content (shown in a collapsible UI
section) while only showing the actual response as text
names instead of "1. Analyze the Request:..."
border matching the existing "Show thinking" section
tracking session error state via existing status update events
Visually differentiate thinking message in chat and fix it so inline thinking is pulled out


before
after
Thinking message was getting in the session autogenerated title like this before the fix
