Skip to content

fix: detect truncated LLM responses in apps extension #7354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DOsinga merged 2 commits into from
Feb 23, 2026
Merged

fix: detect truncated LLM responses in apps extension #7354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae95d70
fix: detect truncated LLM responses in apps extension (#7239)
Feb 19, 2026
ef69782
Remove unit tests from apps extension per review feedback
fresh3nough Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions crates/goose/src/agents/platform_extensions/apps.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,17 @@ impl AppsManagerClient {
let mut model_config = provider.get_model_config();
model_config.max_tokens = Some(16384);

let (response, _usage) = provider
let (response, usage) = provider
.complete(&model_config, session_id, &system_prompt, &messages, &tools)
.await
.map_err(|e| format!("LLM call failed: {}", e))?;

if let (Some(output), Some(max)) = (usage.usage.output_tokens, model_config.max_tokens) {
if output >= max {
return Err("App content generation was truncated because the response hit the token limit. Try simplifying your app description.".to_string());
}
}

extract_tool_response(&response, "create_app_content")
}

Expand Down Expand Up @@ -327,11 +333,17 @@ impl AppsManagerClient {
let mut model_config = provider.get_model_config();
model_config.max_tokens = Some(16384);

let (response, _usage) = provider
let (response, usage) = provider
.complete(&model_config, session_id, &system_prompt, &messages, &tools)
.await
.map_err(|e| format!("LLM call failed: {}", e))?;

if let (Some(output), Some(max)) = (usage.usage.output_tokens, model_config.max_tokens) {
if output >= max {
return Err("App content update was truncated because the response hit the token limit. Try requesting smaller changes.".to_string());
}
}

extract_tool_response(&response, "update_app_content")
}

Expand Down