Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 32 additions & 13 deletions crates/goose/src/agents/agent.rs
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ impl Agent {
}

match agent_ref
.add_extension(config_clone, &session_id_clone)
.add_extension_inner(config_clone, &session_id_clone)
.await
{
Ok(_) => ExtensionLoadResult {
Expand All @@ -700,13 +700,43 @@ impl Agent {
})
.collect::<Vec<_>>();

futures::future::join_all(extension_futures).await
let results = futures::future::join_all(extension_futures).await;

// Persist once after all extensions are loaded
if results.iter().any(|r| r.success) {
if let Err(e) = self.persist_extension_state(&session_id).await {
warn!("Failed to persist extension state after bulk load: {}", e);
}
}

results
}

pub async fn add_extension(
&self,
extension: ExtensionConfig,
session_id: &str,
) -> ExtensionResult<()> {
self.add_extension_inner(extension, session_id).await?;

// Persist extension state after successful add
self.persist_extension_state(session_id)
.await
.map_err(|e| {
error!("Failed to persist extension state: {}", e);
crate::agents::extension::ExtensionError::SetupError(format!(
"Failed to persist extension state: {}",
e
))
})?;

Ok(())
}

async fn add_extension_inner(
&self,
extension: ExtensionConfig,
session_id: &str,
) -> ExtensionResult<()> {
let session = self
.config
Expand Down Expand Up @@ -760,17 +790,6 @@ impl Agent {
}
}

// Persist extension state after successful add
self.persist_extension_state(session_id)
.await
.map_err(|e| {
error!("Failed to persist extension state: {}", e);
crate::agents::extension::ExtensionError::SetupError(format!(
"Failed to persist extension state: {}",
e
))
})?;

Ok(())
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ export const BottomMenuExtensionSelection = ({ sessionId }: BottomMenuExtensionS
const { extensionsList: allExtensions } = useConfig();
const isHubView = !sessionId;

useEffect(() => {
setIsSessionExtensionsLoaded(false);
setSessionExtensions([]);
}, [sessionId]);

useEffect(() => {
const handleExtensionsLoaded = () => {
setRefreshTrigger((prev) => prev + 1);
Expand All @@ -53,8 +58,11 @@ export const BottomMenuExtensionSelection = ({ sessionId }: BottomMenuExtensionS
};
}, []);

// Fetch session-specific extensions or use global defaults
useEffect(() => {
if (refreshTrigger === 0 && !isOpen) {
return;
}

const fetchExtensions = async () => {
if (!sessionId) {
return;
Expand All @@ -75,7 +83,6 @@ export const BottomMenuExtensionSelection = ({ sessionId }: BottomMenuExtensionS
}
};

setIsSessionExtensionsLoaded(false);
fetchExtensions();
}, [sessionId, isOpen, refreshTrigger]);

Expand Down
1 change: 1 addition & 0 deletions ui/desktop/src/hooks/useChatStream.ts
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,7 @@ export function useChatStream({
},
},
});
window.dispatchEvent(new CustomEvent(AppEvents.SESSION_EXTENSIONS_LOADED));
onSessionLoaded?.();
return;
}
Expand Down
Loading