Skip to content

feat: add onFallbackRequest handler to McpAppRenderer #7208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexhancock merged 2 commits into from
Feb 13, 2026
Merged

feat: add onFallbackRequest handler to McpAppRenderer #7208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc41773
feat: add onFallbackRequest handler to McpAppRenderer
aharvard Feb 13, 2026
1d937e0
fix: enhance fallback request handling in McpAppRenderer
aharvard Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ui/desktop/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ui/desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"start-alpha-gui": "ALPHA=true npm run start-gui"
},
"dependencies": {
"@mcp-ui/client": "^6.0.0",
"@mcp-ui/client": "^6.1.0",
"@modelcontextprotocol/ext-apps": "^1.0.1",
"@radix-ui/react-accordion": "^1.2.12",
"@radix-ui/react-avatar": "^1.1.11",
Expand Down
19 changes: 17 additions & 2 deletions ui/desktop/src/components/McpApps/McpAppRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@
* - "standalone" — Goose-specific mode for dedicated Electron windows
*/

import { AppRenderer } from '@mcp-ui/client';
import { AppRenderer, type RequestHandlerExtra } from '@mcp-ui/client';
import type {
McpUiDisplayMode,
McpUiHostContext,
McpUiResourceCsp,
McpUiResourcePermissions,
McpUiSizeChangedNotification,
} from '@modelcontextprotocol/ext-apps/app-bridge';
import type { CallToolResult } from '@modelcontextprotocol/sdk/types.js';
import type { CallToolResult, JSONRPCRequest } from '@modelcontextprotocol/sdk/types.js';
import { useCallback, useEffect, useMemo, useReducer, useState } from 'react';
import { callTool, readResource } from '../../api';
import { AppEvents } from '../../constants/events';
Expand Down Expand Up @@ -400,6 +400,20 @@ export default function McpAppRenderer({
[]
);

const handleFallbackRequest = useCallback(
async (request: JSONRPCRequest, _extra: RequestHandlerExtra) => {
// todo: handle `sampling/createMessage` per https://github.com/block/goose/pull/7039
if (request.method === 'sampling/createMessage') {
return { status: 'success' as const };
}
return {
status: 'error' as const,
message: `Unhandled JSON-RPC method: ${request.method ?? '<unknown>'}`,
};
},
[]
);

const handleError = useCallback((err: Error) => {
console.error('[MCP App Error]:', err);
dispatch({ type: 'ERROR', message: errorMessage(err) });
Expand Down Expand Up @@ -516,6 +530,7 @@ export default function McpAppRenderer({
onReadResource={handleReadResource}
onLoggingMessage={handleLoggingMessage}
onSizeChanged={handleSizeChanged}
onFallbackRequest={handleFallbackRequest}
onError={handleError}
/>
);
Expand Down
Loading