Skip to content

fix: fix windows bundle random failure and optimise canary build #7105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lifeizhou-ap merged 9 commits into from
Feb 10, 2026
Merged

fix: fix windows bundle random failure and optimise canary build #7105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5a180fa
remove unnecessary fetch depth: 0 to optimise the build
lifeizhou-ap Feb 10, 2026
353723a
used http instead of ssh to pull the npm dependency on window
lifeizhou-ap Feb 10, 2026
3b25b80
added dispatch for testing
lifeizhou-ap Feb 10, 2026
088000e
Revert "added dispatch for testing"
lifeizhou-ap Feb 10, 2026
24fd278
make the path consistent with release
lifeizhou-ap Feb 10, 2026
1a8e94b
added another overwrite
lifeizhou-ap Feb 10, 2026
8ca46d5
testing
lifeizhou-ap Feb 10, 2026
adde557
Revert "testing"
lifeizhou-ap Feb 10, 2026
b90c599
removed nightly workflow
lifeizhou-ap Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ jobs:
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
ref: ${{ inputs.ref }}
fetch-depth: 0
Copy link
Copy Markdown
Collaborator

@michaelneale michaelneale Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to do that - will make it a heavier checkout?

Copy link
Copy Markdown
Collaborator Author

@lifeizhou-ap lifeizhou-ap Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fetch-depth is heaviest. by default it is fetch-depth:1 which is the shallow fetch


- name: Update version in Cargo.toml
if: ${{ inputs.version != '' }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/bundle-desktop-intel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ jobs:
with:
# Only pass ref if it's explicitly set, otherwise let checkout action use its default behavior
ref: ${{ inputs.ref != '' && inputs.ref || '' }}
fetch-depth: 0

# Update versions before build
- name: Update versions
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/bundle-desktop-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
ref: ${{ inputs.ref }}
fetch-depth: 0

- name: Update versions
if: ${{ inputs.version != '' }}
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/bundle-desktop-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ jobs:
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
ref: ${{ inputs.ref != '' && inputs.ref || '' }}
fetch-depth: 0

- name: Configure AWS credentials
if: inputs.signing && inputs.signing == true
Expand Down Expand Up @@ -123,6 +122,13 @@ jobs:
echo "Windows-specific files copied successfully"
fi

- name: Force GitHub HTTPS for npm git dependencies
shell: bash
run: |
git config --global url."https://github.com/".insteadOf "ssh://git@github.com/"
git config --global url."https://github.com/".insteadOf "git@github.com:"
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The npm lockfile contains at least one git+ssh://git@github.com/... dependency (e.g., electron/node-gyp), but this rewrite only covers ssh://git@github.com/ and git@github.com:; add an additional insteadOf rule for git+ssh://git@github.com/ so installs are resilient regardless of how npm passes the URL to git on Windows.

Suggested change
git config --global url."https://github.com/".insteadOf "git@github.com:"
git config --global url."https://github.com/".insteadOf "git@github.com:"
git config --global url."https://github.com/".insteadOf "git+ssh://git@github.com/"

Copilot uses AI. Check for mistakes.
git config --global url."https://github.com/".insteadOf "git+ssh://git@github.com/"

- name: Build desktop UI with npm
shell: bash
env:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/bundle-desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ jobs:
with:
# Only pass ref if it's explicitly set, otherwise let checkout action use its default behavior
ref: ${{ inputs.ref != '' && inputs.ref || '' }}
fetch-depth: 0

- name: Debug git status
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
Goose*.zip
*.deb
*.rpm
**/*.flatpak
*.flatpak
download_cli.sh
allowUpdates: true
omitBody: true
Expand Down
129 changes: 0 additions & 129 deletions .github/workflows/nightly.yml
View file
Open in desktop

This file was deleted.

Loading