-
Notifications
You must be signed in to change notification settings - Fork 6k
feat(mcp-apps): add Permission Policy support for sandbox iframes #6947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,13 +14,36 @@ pub struct CspMetadata { | |
| pub resource_domains: Option<Vec<String>>, | ||
| } | ||
|
|
||
| /// Sandbox permissions for MCP Apps | ||
| /// Specifies which browser capabilities the UI needs access to. | ||
| /// Maps to the iframe Permission Policy `allow` attribute. | ||
| #[derive(Debug, Clone, Serialize, Deserialize, ToSchema, PartialEq, Eq, Default)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct PermissionsMetadata { | ||
| /// Request camera access (maps to Permission Policy `camera` feature) | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub camera: Option<bool>, | ||
| /// Request microphone access (maps to Permission Policy `microphone` feature) | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub microphone: Option<bool>, | ||
| /// Request geolocation access (maps to Permission Policy `geolocation` feature) | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub geolocation: Option<bool>, | ||
| /// Request clipboard write access (maps to Permission Policy `clipboard-write` feature) | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub clipboard_write: Option<bool>, | ||
| } | ||
|
|
||
| /// UI-specific metadata for MCP resources | ||
| #[derive(Debug, Clone, Serialize, Deserialize, ToSchema, PartialEq, Eq)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct UiMetadata { | ||
| /// Content Security Policy configuration | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub csp: Option<CspMetadata>, | ||
| /// Sandbox permissions requested by the UI | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub permissions: Option<PermissionsMetadata>, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we make this not Option<> and just provide a default implementation? same as for the booleans above. if we just make them non option booelan and initialize them as false, the generated code becomes cleaner and the client easier to read |
||
| /// Preferred domain for the app (used for CORS) | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub domain: Option<String>, | ||
|
|
@@ -87,6 +110,7 @@ impl McpAppResource { | |
| meta: Some(ResourceMetadata { | ||
| ui: Some(UiMetadata { | ||
| csp: Some(csp), | ||
| permissions: None, | ||
| domain: None, | ||
| prefers_border: None, | ||
| }), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The permissions checks rely on truthiness (e.g.
permissions.camera), so a malformed metadata value like'true'would unintentionally enable the feature; please validate each permission is exactlytruebefore adding it to the allow list.