-
Notifications
You must be signed in to change notification settings - Fork 6k
update doc to remind contributors to activate hermit and document minimal npm and node version #6727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
update doc to remind contributors to activate hermit and document minimal npm and node version #6727
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ec6c605
enforce minimal node and npm version check
lifeizhou-ap 3db068f
upgrade node to v24
lifeizhou-ap 3970381
updated the doc
lifeizhou-ap 84425c5
removed enforce engine check and enhance doc
lifeizhou-ap 670718b
update package lock json
lifeizhou-ap File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| registry=https://registry.npmjs.org/ | ||
| engine-strict=true | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
engine-strict=trueand"node": "^24.0.0"inui/desktop/package.json, anynpm installin this package (including theBundle Desktop (Windows)workflow which currently uses Node 22 viaactions/setup-node) will now fail the engine check; please either align the CI/workflow Node version with^24.0.0or relax/removeengine-strictso existing release workflows continue to run.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lifeizhou-ap is this valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, what copilot said is valid. Now I decided to remove it and not to enforce the check. I've also update the doc so that it is clear for users about the prerequisite of hermit activation