Skip to content

Speed up Databricks provider init by removing fetch of supported models #6616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jh-block merged 3 commits into from
Jan 26, 2026
Merged

Speed up Databricks provider init by removing fetch of supported models #6616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f98fb8
Fix Playwright tests to pass with current UI structure
jh-block Jan 21, 2026
8b34cb0
Add performance tests
jh-block Jan 21, 2026
a90e0b0
Don't fetch the list of supported models from Databricks on init
jh-block Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 1 addition & 26 deletions crates/goose/src/providers/databricks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ impl DatabricksProvider {
let api_client =
ApiClient::with_timeout(host, auth_method, Duration::from_secs(DEFAULT_TIMEOUT_SECS))?;

// Create the provider without the fast model first
let mut provider = Self {
api_client,
auth,
Expand All @@ -143,31 +142,7 @@ impl DatabricksProvider {
retry_config,
name: Self::metadata().name,
};

// Check if the default fast model exists in the workspace
// Generate UUID for this initialization request since no user session exists yet
let session_id = uuid::Uuid::new_v4().to_string();
let model_with_fast =
if let Ok(Some(models)) = provider.fetch_supported_models(&session_id).await {
if models.contains(&DATABRICKS_DEFAULT_FAST_MODEL.to_string()) {
tracing::debug!(
"Found {} in Databricks workspace, setting as fast model",
DATABRICKS_DEFAULT_FAST_MODEL
);
model.with_fast(DATABRICKS_DEFAULT_FAST_MODEL.to_string())
} else {
tracing::debug!(
"{} not found in Databricks workspace, not setting fast model",
DATABRICKS_DEFAULT_FAST_MODEL
);
model
}
} else {
tracing::debug!("Could not fetch Databricks models, not setting fast model");
model
};

provider.model = model_with_fast;
provider.model = model.with_fast(DATABRICKS_DEFAULT_FAST_MODEL.to_string());
Ok(provider)
}

Expand Down
2 changes: 1 addition & 1 deletion ui/desktop/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const config: PlaywrightTestConfig = {
screenshot: 'only-on-failure'
},
outputDir: 'test-results',
preserveOutput: 'failures-only'
preserveOutput: 'always'
};

export default config;
5 changes: 3 additions & 2 deletions ui/desktop/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,9 @@ async function configureProxy() {
if (started) app.quit();

if (process.env.ENABLE_PLAYWRIGHT) {
console.log('[Main] Enabling Playwright remote debugging on port 9222');
app.commandLine.appendSwitch('remote-debugging-port', '9222');
const debugPort = process.env.PLAYWRIGHT_DEBUG_PORT || '9222';
console.log(`[Main] Enabling Playwright remote debugging on port ${debugPort}`);
app.commandLine.appendSwitch('remote-debugging-port', debugPort);
}

// In development mode, force registration as the default protocol client
Expand Down
Loading
Loading