Skip to content

don't add escaping to the command field #6519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamadeo merged 1 commit into from
Jan 15, 2026
Merged

don't add escaping to the command field #6519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ui/desktop/src/components/settings/extensions/subcomponents/ExtensionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import ExtensionItem from './ExtensionItem';
import builtInExtensionsData from '../../../../built-in-extensions.json';
import { quote } from 'shell-quote';
import { ExtensionConfig } from '../../../../api';
import { FixedExtensionEntry } from '../../../ConfigContext';

Expand Down Expand Up @@ -136,7 +135,7 @@ export function getSubtitle(config: ExtensionConfig) {
default:
return {
description: config.description || null,
command: 'cmd' in config ? quote([config.cmd, ...config.args]) : null,
command: 'cmd' in config ? [config.cmd, ...config.args].join(' ') : null,
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple space joining will incorrectly display commands with arguments containing spaces or special characters. For example, if args contain "value with spaces", it will display as ambiguous "cmd value with spaces" instead of properly showing "cmd 'value with spaces'". While this is only for display purposes (not execution), it makes it unclear to users what the actual command structure is. Consider keeping shell-quote for proper visual formatting, or implement proper escaping/quoting logic to handle arguments with spaces and special characters.

Copilot uses AI. Check for mistakes.
};
}
}
Loading