Skip to content

fix(ui): respect width parameter in MCP app size-changed notifications #6376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DOsinga merged 2 commits into from
Jan 28, 2026
Merged

fix(ui): respect width parameter in MCP app size-changed notifications #6376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c46becd
fix(ui): respect width parameter in MCP app size-changed notifications
Abhijay007 Jan 7, 2026
5b85174
refactor: addressed comments
Abhijay007 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ui/desktop/src/components/McpApps/McpAppRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ export default function McpAppRenderer({
});
const [error, setError] = useState<string | null>(null);
const [iframeHeight, setIframeHeight] = useState(DEFAULT_IFRAME_HEIGHT);
const [iframeWidth, setIframeWidth] = useState<number | null>(null);

useEffect(() => {
if (!sessionId) {
Expand Down Expand Up @@ -199,9 +200,10 @@ export default function McpAppRenderer({
[append, sessionId, extensionName]
);

const handleSizeChanged = useCallback((height: number, _width?: number) => {
const handleSizeChanged = useCallback((height: number, width?: number) => {
const newHeight = Math.max(DEFAULT_IFRAME_HEIGHT, height);
setIframeHeight(newHeight);
setIframeWidth(width ?? null);
}, []);

const { iframeRef, proxyUrl } = useSandboxBridge({
Expand Down Expand Up @@ -263,7 +265,8 @@ export default function McpAppRenderer({
ref={iframeRef}
src={proxyUrl}
style={{
width: '100%',
width: iframeWidth ? `${iframeWidth}px` : '100%',
Comment thread
Abhijay007 marked this conversation as resolved.
maxWidth: '100%',
height: `${iframeHeight}px`,
border: 'none',
overflow: 'hidden',
Expand Down
Loading