Skip to content

fix : Custom providers with empty API keys show as configured in desktop #6105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexhancock merged 1 commit into from
Dec 16, 2025
Merged

fix : Custom providers with empty API keys show as configured in desktop #6105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions crates/goose-server/src/routes/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,11 @@ pub fn inspect_keys(
pub fn check_provider_configured(metadata: &ProviderMetadata, provider_type: ProviderType) -> bool {
let config = Config::global();

// TODO(Douwe): if the provider doesn't need an API key, it should be considered configured always
if provider_type == ProviderType::Custom || provider_type == ProviderType::Declarative {
if let Ok(loaded_provider) = load_provider(metadata.name.as_str()) {
return config
.get_secret::<String>(&loaded_provider.config.api_key_env)
.map(|s| !s.is_empty())
.unwrap_or(false);
.is_ok();

@DOsinga DOsinga Dec 13, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this lead to the situation where we think custom providers are configured that are not because they miss the API key?

@Abhijay007 Abhijay007 Dec 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the desktop app, we have a checkbox to control this behavior, marking it as local mode.
For the CLI, it works the same as before, if the user explicitly adds it, we treat it as added; otherwise, it is passed through as-is. I don’t think there is any explicit API-level validation or check for this in the CLI.

image

}
}
// Special case: Zero-config providers (no config keys)
Expand Down