Skip to content

use npx in just generate-openapi #5664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamadeo merged 1 commit into from
Nov 11, 2025
Merged

use npx in just generate-openapi #5664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ generate-openapi:
@echo "Generating OpenAPI schema..."
cargo run -p goose-server --bin generate_schema
@echo "Generating frontend API..."
cd ui/desktop && npm run generate-api
cd ui/desktop && npx openapi-ts

Copilot AI Nov 11, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The openapi-ts command reads configuration from openapi-ts.config.ts which is in the ui/desktop directory. However, the CI workflow at .github/workflows/ci.yml:95 runs npm ci to install dependencies before calling just check-openapi-schema. This change breaks the workflow because npx will need to download @hey-api/openapi-ts on every run instead of using the installed version. Either keep using npm run generate-api (which requires npm ci first), or remove the npm ci step from the CI workflow if you want to rely on npx auto-downloading.

Suggested change
cd ui/desktop && npx openapi-ts
cd ui/desktop && npm run generate-api

Copilot uses AI. Check for mistakes.

@jamadeo jamadeo Nov 11, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this is obviously wrong because CI passed.

But also, npx will run from local node_modules first: https://docs.npmjs.com/cli/v7/commands/npx


# make GUI with latest binary
lint-ui:
Expand Down