-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: improve server error messages to include HTTP status code #5532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
762a353
fix: improve server error messages to include HTTP status code
angiejones fa045d0
removing unreachable code
angiejones 3cb5037
Apply suggestion from @Copilot
angiejones e4312b6
Update crates/goose/src/providers/utils.rs
angiejones 24e6bcb
adding function to eliminate duplicate code
angiejones 356b2ad
to_string > Object
angiejones 54ed5e0
copilot pmo
angiejones 43d6394
fix: handle null payload in server error messages to prevent 'Server …
angiejones 12f6fe2
refactor: use format_server_error_message helper in test expectations
angiejones 539073b
refactor: change format_server_error_message to accept StatusCode ins…
angiejones 2103b21
removing self-explanatory comments
angiejones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't status_code by of ype StatusCode here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh, then I need to add
.as_u16()inside the function. but guess that's negligible. will fix...