refactor: move download_tokenizers.sh to a cargo build script - #490
Closed
alecthomas wants to merge 1 commit into
Closed
refactor: move download_tokenizers.sh to a cargo build script#490alecthomas wants to merge 1 commit into
download_tokenizers.sh to a cargo build script#490alecthomas wants to merge 1 commit into
Conversation
This simplifies the build to just `cargo build`. Also added a rust-toolchain.toml file so that `rustup` will Just Work™️.
lifeizhou-ap
approved these changes
Dec 18, 2024
Collaborator
|
not sure yet as there are a few builds that depend on this |
Collaborator
|
but looks good - but please don't merge, let me do this. |
Collaborator
|
moving to my branch where I will merge it with some other changes for compat: #491 |
Contributor
Author
|
@michaelneale I made another change to the Justfile that replaces an invocation of the script |
Contributor
Author
|
Actually let me send you a new PR... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the build to just
cargo build. Also added a rust-toolchain.toml file so thatrustupwill Just Work™️.