Skip to content

fit: default ollama port #4001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelneale merged 2 commits into from
Aug 12, 2025
Merged

fit: default ollama port #4001

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f64339
don't set when has protocol
michaelneale Aug 11, 2025
038473f
change rules for when to automatically append ollama default port
michaelneale Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions crates/goose/src/providers/ollama.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,14 @@ impl OllamaProvider {

// Set the default port if missing
// Don't add default port if:
// 1. URL explicitly ends with standard ports (:80 or :443)
// 2. URL uses HTTPS (which implicitly uses port 443)
let explicit_default_port = host.ends_with(":80") || host.ends_with(":443");
let is_https = base_url.scheme() == "https";

if base_url.port().is_none() && !explicit_default_port && !is_https {
// 1. URL/host explicitly contains ports
// 2. URL/host uses HTTP/S
// 3. only set it for localhost
let explicit_port = host.contains(':');
let is_localhost = host == "localhost" || host == "127.0.0.1" || host == "::1";

if base_url.port().is_none() && !explicit_port && !host.starts_with("http") && is_localhost
{
base_url
.set_port(Some(OLLAMA_DEFAULT_PORT))
.map_err(|_| anyhow::anyhow!("Failed to set default port"))?;
Expand Down
Loading