[WIP] feat: Added scroll state support for chat-session-list navigation - #3684
Closed
tiensi wants to merge 2 commits into
Closed
[WIP] feat: Added scroll state support for chat-session-list navigation#3684tiensi wants to merge 2 commits into
tiensi wants to merge 2 commits into
Conversation
tiensi
changed the title
tiensi
changed the title
tiensi
force-pushed
the
vhuang/retain-chat-session-scroll-state
branch
from
July 28, 2025 03:53
0ac3fd2 to
2f91333
Compare
tiensi
force-pushed
the
vhuang/retain-chat-session-scroll-state
branch
from
July 28, 2025 04:01
2f91333 to
921a8ab
Compare
tiensi
marked this pull request as ready for review
July 28, 2025 04:06
1 task
zanesq
reviewed
Jul 28, 2025
zanesq
left a comment
zanesq
left a comment
Contributor
There was a problem hiding this comment.
I tested this locally and it didn't seem to scroll to the position after going back for me, maybe it needs to wait for the entire list to load first? Also, I think this is a bit more complex because ideally it would handle the search case also where sessions are filtered after searching with cmd/ctrl + f.
Contributor
Author
|
Thanks for the heads up, I'll test a bit more and take a look at the search use case. |
tiensi
changed the title
Collaborator
|
@tiensi still updated it - you interested in this - still an issue? |
Contributor
Author
|
Thanks for the reminder, let me close this for now to reduce noise until I can get a more robust fix in. |
Contributor
Author
|
This was stale so I rebuilt it here: #4360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSED
NEW PR HERE
Summary
Added scroll state memory when navigating back from session view.
Changes
showSessionHistoryto SessionsView to replace reliance onselectedSessionbeing nullselectedSessionas a new prop toSessionListViewso that it can scroll to a selected sessionuseEffectfor scrolling inSessionListViewRequest
#3664
After Changes
Screen.Recording.2025-07-27.at.8.28.48.PM.mov
Before
Screen.Recording.2025-07-27.at.8.29.32.PM.mov