Skip to content

Expand databricks agent error handling to fallback to token limit errors#3535

Closed
zanesq wants to merge 4 commits into
mainfrom
zane/fallback-error-token-limits
Closed

Expand databricks agent error handling to fallback to token limit errors#3535
zanesq wants to merge 4 commits into
mainfrom
zane/fallback-error-token-limits

Conversation

@zanesq

@zanesq zanesq commented Jul 20, 2025

Copy link
Copy Markdown
Contributor

I noticed the UI shows a generic 401 unauthorized (occasionally) or 400 bad request from Databricks when a token limit is reached instead of kicking off the auto summarization. It doesn't recognize that its a token limit error because the message doesn't have the phrases we look for like "token limit" in the error message. It appears to be a token limit issue because manually using the summarize feature allows chat to continue while just sending a chat message without summarization does not.

This adds fallback logic to work around that and allows the UI to handle it gracefully by allowing chat to continue with auto summarize.

Screenshot 2025-07-19 at 7 17 26 PM

zanesq added 4 commits July 20, 2025 09:49
* 'main' of github.com:block/goose:
  Catch json errors a little better (#3437)
  Rust debug (#3510)
  refactor: Centralise deeplink encode and decode into server (#3489)
@zanesq zanesq marked this pull request as ready for review July 21, 2025 18:34
@DOsinga

DOsinga commented Jul 22, 2025

Copy link
Copy Markdown
Collaborator

thanks for looking into this. I don't think we should be adding more ad hoc checks like this to providers though. my approach is this: #3558 -- add universal error parsing and retry logic to all providers.

@zanesq

zanesq commented Jul 22, 2025

Copy link
Copy Markdown
Contributor Author

Makes sense, I'll close for now. Lets see if this fixes the issue and we might not need this.

@zanesq zanesq closed this Jul 22, 2025
@DOsinga DOsinga deleted the zane/fallback-error-token-limits branch May 14, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants