Skip to content

Fix window not showing for some users #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanesq merged 4 commits into from
Jun 17, 2025
Merged

Fix window not showing for some users #2967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff8413f
Change so the main window is created and displayed immediately withou…
zanesq Jun 17, 2025
db8d263
fix merge issue
Jun 16, 2025
1c5a074
Fix goosed launch failure due to invalid working directories
zanesq Jun 17, 2025
41cdcdb
Add security enhancements to directory validation
zanesq Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions ui/desktop/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions ui/desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@
"tailwind-merge": "^2.5.4",
"tailwindcss-animate": "^1.0.7",
"unist-util-visit": "^5.0.0",
"uuid": "^11.1.0",
"yauzl": "^3.0.0"
"uuid": "^11.1.0"
}
}
17 changes: 13 additions & 4 deletions ui/desktop/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,12 +1220,9 @@ const registerGlobalHotkey = (accelerator: string) => {
};

app.whenReady().then(async () => {
// Register update IPC handlers once
// Register update IPC handlers once (but don't setup auto-updater yet)
registerUpdateIpcHandlers();

// Setup auto-updater if enabled
shouldSetupUpdater() && setupAutoUpdater();

// Add CSP headers to all sessions
session.defaultSession.webRequest.onHeadersReceived((details, callback) => {
callback({
Expand Down Expand Up @@ -1296,6 +1293,18 @@ app.whenReady().then(async () => {

await createNewWindow(app, dirPath);

// Setup auto-updater AFTER window is created and displayed (with delay to avoid blocking)
setTimeout(() => {
if (shouldSetupUpdater()) {
log.info('Setting up auto-updater after window creation...');
try {
setupAutoUpdater();
} catch (error) {
log.error('Error setting up auto-updater:', error);
}
}
}, 2000); // 2 second delay after window is shown

// Get the existing menu
const menu = Menu.getApplicationMenu();

Expand Down